[GitHub] cordova-docs pull request: CB-11006 add ios@4.1.1 release blog pos...

2016-04-04 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-docs/pull/571 CB-11006 add ios@4.1.1 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-docs CB-11006 Alternatively

[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...

2016-02-16 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-184741324 @infil00p and @csantanapr can you take a look at this and see if you have any problems with it? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...

2016-02-16 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/17 CB-10624 remove error message from whitelist.js, which leaves it empty You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugin-globalization pull request: CB-10605 fix deprecatio...

2016-02-15 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/44#issuecomment-184342462 Thanks @jcesarmobile. I'll merge it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-plugin-splashscreen pull request: CB-10606 fix deprecation...

2016-02-15 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/82#issuecomment-184342200 Thanks @jcesarmobile. I'll merge it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-plugin-splashscreen pull request: CB-10606 fix deprecation...

2016-02-12 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/82 CB-10606 fix deprecation warning for interfaceOrientation You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova

[GitHub] cordova-plugin-globalization pull request: CB-10605 fix deprecatio...

2016-02-12 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/44 CB-10605 fix deprecation warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-globalization

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163419109 Can do @tony-- . I'll add it in and merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-09 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163319161 @csantanapr I have updated my pull request per your comments and suggestions --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-07 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/182 CB-10162 correct the paths for iOS icon and splashscreen resources You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-ios

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-03 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153361722 sounds good. thanks @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152611628 @omefire I've started a discussion thread for this on the dev list --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152596207 Thanks @nikhilkh! I'll take a look at the jshint failure and fix it --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-29 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-lib/pull/334 CB-9901 cordova plugin search opens in a browser You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-lib CB-9901

[GitHub] cordova-ios pull request: CB-9719 set allow_non_modular_includes t...

2015-10-07 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/171 CB-9719 set allow_non_modular_includes to yes Ran into some issues with git so did a new pull request. @shazron @csantanapr I added that setting change in build.xcconfig and confirmed that it

[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...

2015-10-07 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-ios/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...

2015-10-02 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/170 CB-9719 set enable_modules build setting to no In 3.x, this setting was set to no. It currently breaks frameworks that have CordovaLib as a dependency since it is not a module. You can

[GitHub] cordova-lib pull request: CB-8733 cordova plugin save should also ...

2015-09-10 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-lib/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-globalization pull request: CB-9409 check that loca...

2015-08-27 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/39#issuecomment-135553374 @shazron Your comparison makes more sense to me as well. I've updated the commit. Thanks! --- If your project is set up for it, you can rep

[GitHub] cordova-plugin-globalization pull request: CB-9409 check that loca...

2015-07-24 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/39 CB-9409 check that localeIdentifier has underscore You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova

[GitHub] cordova-ios pull request: CB-9088 sms urls won't open in iframe

2015-05-28 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/143 CB-9088 sms urls won't open in iframe You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-ios CB-9088 Alternatively yo

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-05-18 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-103238194 bump Any update on this? Running into issues because of it. Thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-legacy-whitelist pull request: CB-8660 remove extra...

2015-03-24 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-plugin-legacy-whitelist/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

2015-01-13 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/57#issuecomment-69776455 The crash in spec "filetransfer.spec.25 should handle unknown host" was caused in removeTargetFile. For spec25, the path at that point wa

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

2015-01-13 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/57 CB-8296 add check at removeTargetFile to see if file exists You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-05 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65794810 Hi @oliversalzburg , the way I have implemented it that should be expected. iOS won't compile on anything other than OSX. I have included an explanation for

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-01 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65124881 Could someone take a look at this and provide some feedback? An explanation of these changes can be found here https://issues.apache.org/jira/browse/CB-7803

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-01 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-lib/pull/126 CB-7803 allow adding any platform on any workstation OS You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-lib CB-7803

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-06 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61998319 Sure thing. Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61886196 Thanks @shazron . I had someone test it on Windows, then I pulled their project to my Mac and made sure that the project would build and run when created from

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-04 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/118 CB-5706 convert some of the bash scripts to nodejs only converted the ones necessary to allow iOS project management on a nonsupported OS You can merge this pull request into a Git

[GitHub] cordova-mobile-spec pull request: CB-7423 change failing whitelist...

2014-10-15 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/107#issuecomment-59204926 Closing since fix was already added to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-mobile-spec pull request: CB-7423 change failing whitelist...

2014-10-15 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-7727 add resolution part to 'backup t...

2014-10-07 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/113 CB-7727 add resolution part to 'backup to icloud' warning message You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cord

[GitHub] cordova-coho pull request: CB-6722 added check-license to the docs

2014-10-06 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-coho/pull/51 CB-6722 added check-license to the docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-coho CB-6722 Alternatively you

[GitHub] cordova-plugin-inappbrowser pull request: CB-7720 check if event i...

2014-10-06 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/68 CB-7720 check if event is null since OK string from success callback was... ... removed You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-coho pull request: CB-6722 add feature to check licenses o...

2014-10-03 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-coho/pull/50 CB-6722 add feature to check licenses of third-party dependencies Also flags any packages whose licenses may not be accepted You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-camera pull request: CB-7423 do cleanup after copyI...

2014-09-17 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs pull request: CB-7565 add debugging guide for iOS wit...

2014-09-17 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-docs/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-7565 add debugging guide for iOS wit...

2014-09-16 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-docs/pull/237 CB-7565 add debugging guide for iOS with references to xcode and safari web inspector You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-mobile-spec pull request: CB-7423 change failing whitelist...

2014-09-09 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/107 CB-7423 change failing whitelist test by adding a pattern it should matc... ...h Previous test was assuming that the pattern "file:///*" was added to the whitel

[GitHub] cordova-plugin-camera pull request: CB-7423 do cleanup after copyI...

2014-09-04 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/47 CB-7423 do cleanup after copyImage manual test Running the copy, write, or upload manual tests after doing a copy and without retaking or reselecting an image will cause the test to

[GitHub] cordova-plugin-file-transfer pull request: CB-7423 fix spec28,29 l...

2014-09-02 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/42#issuecomment-54218903 This fixes a test issue that was throwing a "ReferenceError" to lastProgressEvent in specs 28 and 29 --- If your project is set up f

[GitHub] cordova-plugin-file pull request: CB-7423 encode path before attem...

2014-09-02 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-file/pull/78 CB-7423 encode path before attempting to resolve For some of the tests in mobilespec, files aren't getting deleted at cleanup so you get a PATH_EXISTS error on the second run

[GitHub] cordova-plugin-file-transfer pull request: CB-7423 fix spec28,29 l...

2014-09-02 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/42 CB-7423 fix spec28,29 lastProgressEvent not visible to afterEach functio... ...n You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-statusbar pull request: CB-6724

2014-08-19 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-vibration pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/20 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-vibration CB

[GitHub] cordova-plugin-statusbar pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/14 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-statusbar CB

[GitHub] cordova-plugin-splashscreen pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/25 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-splashscreen

[GitHub] cordova-plugin-network-information pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/17 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin

[GitHub] cordova-plugin-media-capture pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/24 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-media

[GitHub] cordova-plugin-media pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-media/pull/25 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-media CB-6724

[GitHub] cordova-plugin-geolocation pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/23 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-geolocation

[GitHub] cordova-plugin-file-transfer pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/40 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-file

[GitHub] cordova-plugin-file pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-file/pull/68 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-file CB-6724

[GitHub] cordova-plugin-dialogs pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/26 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-dialogs CB-6724

[GitHub] cordova-plugin-device-orientation pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/13 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-device

[GitHub] cordova-plugin-device-motion pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/17 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-device

[GitHub] cordova-plugin-device pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-device/pull/22 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-device CB-6724

[GitHub] cordova-plugin-contacts pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/42 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-contacts CB-6724

[GitHub] cordova-plugin-camera pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/42 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-camera CB-6724

[GitHub] cordova-plugin-battery-status pull request: CB-6724

2014-08-18 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/16 CB-6724 documentation for manual tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-plugin-battery

[GitHub] cordova-plugin-vibration pull request: Cb 7138

2014-07-23 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/17 Cb 7138 Added more test cases for old vibration calls and added test cases for new vibration calls that align with w3c spec You can merge this pull request into a Git repository

[GitHub] cordova-plugin-vibration pull request: Cb 5459

2014-07-23 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/16 Cb 5459 Changes on js code and Android code to align with w3c spec You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale