Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/55
AndroidThings: Enable Cordova-plugin-vibration on Android Things platâ¦
â¦form
The vibrate device is using driver-pwmspeaker library.
You can merge this pull request
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/51
AndroidThings: Enabling device motion plugin with ump library
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fujunwei
GitHub user fujunwei reopened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/54
AndroidThings: Enable Cordova-plugin-vibration on Android Things platâ¦
â¦form
The vibrate device is using ump buzzer library.
You can merge this pull request
Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/54
AndroidThings: Enable Cordova-plugin-vibration on Android Things platâ¦
â¦form
The vibrate device is using ump buzzer library.
### Platforms affected
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
All the tests has passed after updating the latest codes, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
There is a test failed on SM-G9250.
> org.apache.cordova.unittests.IFrameTest > iFrameHistory[SM-G9250 - 6.0.1]
FAILED
at junit.framework.Assert.fail(Assert.j
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
Do you mean the failed test will be continue to fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
It hangs on running unit tests with `./gradlew connectedAndroidTest`, the
output logs:
> org.apache.cordova.unittests E/AndroidProtocolHandler: Unable to open
asset URL: f
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/166
@stevengill @nikhilkh PTAL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/166
Don't crash on low memory devices
It will be OOM when running file-transfer tests on baseline Android Memory
class
which is 16M (It happens to be the java heap limit
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/211#issuecomment-136538202
@agrieve
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/211
The extra digit need to be added to the end of the version code
The version code of default config is generated by the environment variable
and the value from AndroidManifest.xml
Github user fujunwei commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/247#discussion_r35481753
--- Diff:
cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml ---
@@ -0,0 +1,16 @@
+?xml version=1.0 encoding=UTF-8
Github user fujunwei commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/247#discussion_r35388232
--- Diff:
cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml ---
@@ -0,0 +1,16 @@
+?xml version=1.0 encoding=UTF-8
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/118#issuecomment-72810628
@agrieve Mybe we need git clone cordova-crosswalk-engine in top dir
manually, is it right? PTAL. thanks.
---
If your project is set up for it, you can
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/118
Add a --webview flag to createmobilespec.js
Use Crosswalk webview instead of Android webview with --webview=crosswalk
You can merge this pull request into a Git repository by running
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/140#issuecomment-70243782
ping @clelland PTAL, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/140#issuecomment-69277448
ping @clelland Could you please help me review this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/141
Build multiple apks by default
The xwalk webView need build multiple apks by default after install
cordova-crosswalk-engine plugin, we can set ext.multiarch=true to open the flag
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-67913750
Thanks. it's fine after updating your commit. I want to build multiple apks
after install plugin by default, don't necessary set system environment
manually
Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-android/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-67914483
The cordova-crosswalk-engine master branch don't use the aar format, could
you help to merge the aar branch to master? And the PR
https://github.com
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-67916137
I have requested a PR that make Cordova upstream JUnit tests to test
pluggable webview https://github.com/apache/cordova-android/pull/140, could
you please
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/141#issuecomment-67924015
Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-67924041
Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/140#issuecomment-67446387
Could someone help me to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/140
Make JUnit tests to test pluggable webview
The JUnit tests can only test Android webView now, the XWalk is a pluggable
webView, we want to reuse the tests to test the pluggable webView
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-67095787
@clelland My Gradle version is 1.12, and the Android plugin version is
0.12.0. You need set ext.multiarch=true to build multiple apks, and use
./cordova/build
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-66951476
ping @clelland Could you please help to review it, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/138
Fix compile error when build multiple apks
Task 'lintVitalRelease' not found in root project when build multiple apks,
add a empty task for comipling.
You can merge this pull request
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/138#issuecomment-66743053
@clelland PTAL. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-66214909
Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-65731000
The PR have been blocked two weeks, Could someone help to merge it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-65337922
ping @clelland, Do you have other update on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-65027078
@clelland Could you please help to take a look on this PR?
the commit
https://github.com/MobileChromeApps/cordova-crosswalk-engine/commit
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-64165859
ping @agrieve @clelland Please take a look, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-63572629
Yes, Thanks @clelland for detailed explain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/133
Add a section for plugin extensions
The build.gradle will apply gradle srcipte from plugin extension When
install the plugin with gradleReference framework.
The gradle can set
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/133#issuecomment-63270973
@agrieve @clelland PTAL. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-63012342
ping @clelland @agrieve again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-62823008
ping @clelland @agrieve Could you please help to take a look, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-lib/pull/119
Add a type named gradleReference in framework
It's too complex to dependence AAR in plugin, it need build the plugin
to a android project which include AndroidManifest.xml. This patch
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-62672178
The Cordova 4.0 have the same feature as Android: Add library projects to
gradle build config
(https://github.com/apache/cordova-lib/commit
Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-lib/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/117#issuecomment-62483257
@clelland What happens on upgrade, if a project already has a
platforms/android/build.gradle file? Do we need to put some code in to either
replace build.gradle
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/117#issuecomment-62328445
@agrieve @clelland PTAL. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62082241
I think we should add the two lines automatically when upgrade the project.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62096240
Tests should be updated with this as well (although they were failing on
the branch before this PR)
There are no settings.gradle and libraries.gradle files
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-lib/pull/117
Add comment section at end of build.gradle
If a project already has a build.gradle file when upgrade Cordova, we
should add the comment section automatically when install the plugin.
You can
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61920987
@agrieve @clelland PTAL. Thanks.
The blow section will commit to ./bin/remplates/project/build.gradle
// PLUGIN GRADLE EXTENSIONS START
// PLUGIN
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61446454
ping @clelland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61198123
hi @clelland , Could you give some suggestion on the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-60540658
hi @clelland, Is it a good approach to use Maven library in plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-lib/pull/111
Add a type named gradleReference in framework
It's too complex to dependence AAR in plugin, we need build the plugin to a
android project which include AndroidManifest.xml. This patch
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-60359665
@clelland PTAL. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
59 matches
Mail list logo
