[GitHub] cordova-mobile-spec pull request: CB-6369:Update the descriptions ...

2014-03-30 Thread lmnbeyond
Github user lmnbeyond commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/53#issuecomment-39048158 @cmarcelk Thanks for your tips, I have updated my github profile. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-mobile-spec pull request: CB-6369:Update the descriptions ...

2014-03-27 Thread lmnbeyond
GitHub user lmnbeyond opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/53 CB-6369:Update the descriptions of expected results for InAppBrowser ope... ...nWithScript tests. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS:Fix the probl...

2014-03-23 Thread lmnbeyond
Github user lmnbeyond commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/3#issuecomment-38384935 If I set web view frame as main screen bounds in pluginInitialize: , then the web view frame will be set again later to another value. However I can&#

[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS:Fix the probl...

2014-03-23 Thread lmnbeyond
Github user lmnbeyond closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS:Fix the probl...

2014-03-20 Thread lmnbeyond
Github user lmnbeyond commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/3#issuecomment-38247400 @shazron Thanks for your kindly review, I really don't want to break any functionalities, I'm so sorry :( I have tired my best

[GitHub] cordova-plugin-statusbar pull request: CB-6318 iOS:Fix the probl...

2014-03-20 Thread lmnbeyond
GitHub user lmnbeyond opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/3 CB-6318 iOS:Fix the problem that Statusbar can't blend into the backgrou... ...nd when embedding CDVViewController in a NavigationController You can merge this pull re

Re: [Vote] Cordova 3.4.0 release

2014-02-18 Thread lmnbeyond
+1 Best Regards! > +1 > > On 2/18/14 3:26 PM, "Steven Gill" wrote: > >> Please review and vote on the Cordova 3.4.0 release. >> >> You can find the sample release at http://people.apache.org/~steven/ >> >> Voting will go on for 24 hours. >> >> Cheers, >> >> -Steve >

About PR and stale branches

2014-01-22 Thread lmnbeyond
Hi, 1. I’m wondering would it be better if we can clean up and merge the “open” pull requests before we do a release. As for me, if my pull requests can’t be merged into the coming release, it would make me a little frustrated. In fact, as a contributor, I’d like my PR to get accepted as soon a

Should we add platform info in commit message?

2013-10-17 Thread lmnbeyond
Hi guys, Since plugin-related code are all grouped into its own repo, should we add platform info in commit messages? I think it would be more clear when we view the commit history. e.g., [CB-1234][iOS] Fix… [CB-5678][all] Fix… [Android]… [js]… What do you think, guys? Best Regards!

Re: What's your daily workflow for cordova development?

2013-09-04 Thread lmnbeyond
> I also think it should sub-shell to a platform script. We already have > a `project template` folder in each platform. We can easily add a > `plugin template` as well and write a quick create_plugin script. > > What do you guys think of the workflow I described above ? Any > comments ? I can c

Re: What's your daily workflow for cordova development?

2013-09-02 Thread lmnbeyond
+ 1 love "watch command" idea :) Best Regards! On 2013-9-3, at 上午7:34, Brian LeRoux wrote: > automate > add/remove with some sort of watch command. That way ppl are writing to the > plugin spec from the beginning instead of refactoring a plugin out of a > native project.

Re: cli plugins 'alias'?

2013-09-02 Thread lmnbeyond
+ 1 It's great Best Regards! On 2013-9-3, at 上午8:37, Brian LeRoux wrote: > love this idea > > > On Sat, Aug 31, 2013 at 2:36 PM, Jonathan Bond-Caron < > jbo...@gdesolutions.com> wrote: > >> Setting up the mobile spec app was tedious since I didn't know the >> dependencies. >> >> I wrote

Re: What's your daily workflow for cordova development?

2013-09-01 Thread lmnbeyond
rsions of platforms or the core >>>> plugins, you are free to clone the git repos manually, and use >>> cordova-cli >>>> to add them from local paths. This way, you can also make downstream >>>> changes inside feature branches etc. >>>> >>>

What's your daily workflow for cordova development?

2013-08-30 Thread lmnbeyond
Hi all, Cordova was separated into tens of individual repos ever since 3.0 and we're benefit from this change and can quickly build/test apps. For now, if I want to develop some feature or plugin, I can first create a project by cli, then did some changes, but meanwhile it's dif

Re: Pull requests

2013-08-19 Thread lmnbeyond
Hi all, That's right, my name is Meina Liu :) Best Regards! On 2013-8-20, at 上午4:10, Max Woghiren wrote: > I believe it's Meina Liu—the confirmation was sent on June 3rd. > > I'll pull these changes in. > > On Mon, Aug 19, 2013 at 4:07 PM, Andrew Grieve wrote:

Pull requests

2013-08-18 Thread lmnbeyond
Hi all, I want to do some contribution to Cordova, and I have tried to fix some minor issues: repo: cordova-plugin-contacts https://issues.apache.org/jira/browse/CB-4580 pull request: https://github.com/apache/cordova-plugin-contacts/pull/5/commits repo: cordova-ios https://issues.apac