GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/187
CB-12809: Google Play Blocker: Unsafe SSL TrustManager Defined
### Platforms affected
Android
### What does this PR do?
It removes
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-coho/pull/156
Remove cordova-plugin-compat
### Platforms affected
Android
### What does this PR do?
Removes cordova-plugin-compat from cordova-coho
### What testing has
Github user macdonst commented on the issue:
https://github.com/apache/cordova-android/pull/399
@filmaj rebased and pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-android/pull/399
CB-12730: Compat - INTEGRATE
### Platforms affected
Android
### What does this PR do?
This PR integrates cordova-plugin-compat directly into cordova
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122787134
--- Diff: cordova-lib/cordova.js ---
@@ -1486,6 +1486,26 @@ module.exports = {
bootstrap: function() {
+var cache
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122782989
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122785379
--- Diff: bin/template/www/cordova-sw.js ---
@@ -0,0 +1,23 @@
+
+// Note, these will be updated automatically at build time
+var
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122786300
--- Diff: bin/template/www/manifest.json ---
@@ -0,0 +1,21 @@
+{
+ "name": "My App",
+ "short_name"
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122780778
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122783962
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122786410
--- Diff: cordova-js-src/confighelper.js ---
@@ -61,14 +61,9 @@ function readConfig(success, error
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122782108
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/53
CB-12726: Device Motion - SUNSET
### Platforms affected
All
### What does this PR do?
Add's deprecation notice to the repo
### What testing
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/36
CB-12728: Device Orientation - SUNSET
### Platforms affected
All
### What does this PR do?
Add's deprecation notice to the repo
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/30#discussion_r119261228
--- Diff: bin/template/cordova/Api.js ---
@@ -96,6 +96,42 @@ Api.createPlatform = function (dest, config, options,
events
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/30#discussion_r118943490
--- Diff: bin/template/cordova/Api.js ---
@@ -96,6 +96,40 @@ Api.createPlatform = function (dest, config, options,
events
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/30#discussion_r118941014
--- Diff: bin/template/cordova/Api.js ---
@@ -96,6 +96,40 @@ Api.createPlatform = function (dest, config, options,
events
Github user macdonst commented on the issue:
https://github.com/apache/cordova-browser/pull/30
@audreyso looks good. Is there a follow up issue to read the `icon` tag
from config.xml and add it to the manifest?
---
If your project is set up for it, you can reply to this email
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/77
This PR is good to merge and we should look at removing reflection from the
rest of the plugin.
---
If your project is set up for it, you can reply to this email and have your
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103261864
--- Diff: src/android/StatusBar.java ---
@@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String
colorPref
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103260428
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103258589
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-android/pull/376
Fix for CB-12015: initial-scale values less than 1.0 are ignored on Android
### Platforms affected
Android
### What does this PR do?
Fixed an issue where
Github user macdonst closed the pull request at:
https://github.com/apache/cordova-android/pull/332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103127274
--- Diff: src/android/StatusBar.java ---
@@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String
colorPref
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103126865
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103126947
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/127
@jcesarmobile yes, merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user macdonst commented on the issue:
https://github.com/apache/cordova-lib/pull/453
@shazron don't think we should as `edit-config` can add/modify the
strings.xml file on Android just as easily as AndroidManifest.xml.
---
If your project is set up for it, you can reply
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-android/pull/332
Enable background start of Cordova Android apps
This is to allow a push notification to tell the app to start in the
background.
You can merge this pull request into a Git repository
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-network-information/pull/45
@NickyYo thanks for that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user macdonst commented on the issue:
https://github.com/apache/cordova-docs/pull/614
@ktop looks good but my personal preference would be to show a before and
after of the Android Manifest.xml you use in your example to really hammer home
how it works.
---
If your project
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/103
@vladimir-kotikov ah, awesome. I did not load the link. I mistakenly
assumed it was a finite length based on file extension. LGTM!
---
If your project is set up for it, you can reply
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/103
@vladimir-kotikov but then we are not playing a shoutcast stream so I'm not
sure if it keeps in the spirt of the original tests.
---
If your project is set up for it, you can reply
Github user macdonst commented on the issue:
https://github.com/apache/cordova-lib/pull/453
@dpogue yeah, I agree that it is a common use case. One reason I bring it
up is you may be able to re-use some code that @ktop is landing into
cordova-common. Also, I mis-spoke as Karen's
Github user macdonst commented on the issue:
https://github.com/apache/cordova-lib/pull/453
@dpogue take a look at this PR
https://github.com/apache/cordova-lib/pull/449. It should allow for the editing
of anything in AndroidManifest.xml. Currently it works for plugin.xml
Github user macdonst commented on the issue:
https://github.com/apache/cordova-lib/pull/449
LGTM! Sorry for taking so long. My workspace is in a bad way and I think I
need to kill it with fire and setup the whole thing from scratch.
Once this gets into a release I have about
Github user macdonst commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@ktop I also see "unknown" for your name in `git log`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/77
@lucViana thanks for the PR but we fixed it a different way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user macdonst commented on the issue:
https://github.com/apache/cordova-android/pull/309
@infil00p should we leave `mavenCentral` in just in case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-219075301
@ktop, @stevengill my environment seems to be in a bad state. I've got
problems with cordova-fetch and the new telemetry stuff I'm working through.
Right now when
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-218824969
@stevengill it was working pretty good last I checked. With the config.xml
stuff in it should be ready to go. I've earmarked some time tomorrow to do my
testing
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-217228255
@ktop thanks for the hint about running `cordova-coho/coho npm-link`. Once
I did I was able to get your code to run. It seems to be working pretty good to
me. So
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464
@ktop @riknoll yeah, config.xml should be part of this. Anything in
config.xml should trump whatever is specified in the plugin.xml. If we do modes
then default
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215811240
@ktop Yeah, I have the `attr="true"` in my plugin.xml and it still gets
added instead of merged.
```
```
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213519895
@ktop I did a quick test of this with one of my existing apps and it does
add the following lines to AndroidManifest.xml
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-209689870
@silhouettes I don't think @stevengill will reply on this thread but maybe
now that he's been @ messaged. I'm sure there will be a plugins release
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208579024
@rakatyal no one really responded with a date and I'm going to hand it over
to Steve to get the release out.
---
If your project is set up for it, you
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-202658419
@winstef it's more likely to get merged if someone updates it to remove the
merge conflicts.
---
If your project is set up for it, you can reply
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194592028
@riknoll yeah, we shouldn't let people into the gallery if we can't read
the file later.
If we can't tell which gallery they will use
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194582918
@riknoll if you call getPicture() to read from the gallery shouldn't it
request READ permission before opening the gallery?
---
If your project is set
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-android/pull/247#issuecomment-168793665
@dpogue I'm currently doing the same thing in the push plugin to fix the
issue. So I'm :+1: on this change.
---
If your project is set up for it, you can
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/146#issuecomment-154414663
@jasongin +1
Yeah, the change to compatibility looks like a mistake. It is supposed to
be "internal" as of the 3.0.0 release.e
-
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-android/pull/227
Move CordovaWebView to CordovaWebInterface
As discussed on at the face to face we should rename this interface.
You can merge this pull request into a Git repository by running
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-147934476
I'm not in favor of this PR being merged into master as I don't think we
should add the functionality CB-7015 asks for. There is no need to add a new
tag
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-ios/pull/169
CB-9721 Set ENABLE_BITCODE to NO in build.xcconfig
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-ios CB-9721
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/167#issuecomment-142941572
Yes, that is the intention. Comments on the JIRA ticket don't show up in
this PR but that is our plan.
---
If your project is set up for it, you can reply
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-ios/pull/165
CB-9552 Updating linked platform removes original files
If symlink then just unlink not recursive removal of directory.
You can merge this pull request into a Git repository by running
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-ios/pull/167
CB-9690 Can't submit iPad apps to the App Store for iOS 9
Closes something
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/60#issuecomment-142012100
@ghenry22 Why did you close this PR? It doesn't appear it ever got merged.
---
If your project is set up for it, you can reply to this email and have
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140620008
@shazron Yeah, I didn't bother to update to 5.0.1 as it only affects the
project when used as a CLI but I can do that if you'd like.
I actually did get
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-140149314
@shazron okay, I think I've got it. I don't want to merge until I get a
second set of eyes though.
---
If your project is set up for it, you can reply
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139687899
@shazron thanks for the feedback, I meant to ask about including npm
modules along with the cordova-ios. This way folks would not need to `npm
install ios-sim
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-ios/pull/160
CB-9328 Use ios-sim as a node module, not a CLI utility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-ios CB-9328
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138648374
I'm working on merging this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138655645
I committed a fix for this so this PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/42
CB-9249 Fix iOS warnings in Media Capture plugin Part 2
Apparently this is a trivial change but I'd like someone to look it over.
This is where I got the fix
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/291#issuecomment-137230594
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/41
CB-9249 Fix iOS warnings in Media Capture plugin
Needs a code review.
This removes the compiler warnings in Xcode.
You can merge this pull request into a Git
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-126738049
@jcesarmobile Good point, not sure how to handle it short of telling them
not to copy and stick with compatibility for their app.
Also, I've
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-126341456
@purplecabbage we make developers migrate the files if they want to go
through the trouble. If they don't want to do that they can always get the old
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125647394
@purplecabbage I don't think we need to do this as a user of an older
version of this plugin only needs to set the preference
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/127
Make Android default persistent file location internal
**TL;DR Summary**
We should switch the default for the Cordova Android File System to be on
internal storage
Github user macdonst closed the pull request at:
https://github.com/apache/cordova-android/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
74 matches
Mail list logo
