[GitHub] cordova-android pull request: CB-10680 Expose useHttpAuthUsernameP...

2016-02-23 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-android/pull/262 CB-10680 Expose useHttpAuthUsernamePassword in ICordovaHttpAuthHandler You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-09-04 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137896650 Thanks! Please look at merging CB-9560 when you time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-09-04 Thread marcuspridham
Github user marcuspridham closed the pull request at: https://github.com/apache/cordova-lib/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-09-04 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137878645 Yep. I signed the ICLA awhile ago. I have done some pull requests to Cordova before. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-136482068 Thanks. I just tried these cases it appears to already work. The search path provided with prepare passes through https://github.com/apache/cordova-lib/blob

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-lib/pull/292 CB-8993 Plugin restore ignores search path When restoring a platform the search path needs to be provided otherwise plugins will always be resolved to npm. You can merge this pull

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-28 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135886715 In serial it seems to be able to detect the file plugin is already installed and does not try to install it again. The parallel way you can see in the logs

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-27 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135579250 Yep it does seem to happen with cordova-plugin-file-transfer and cordova-plugin-file. I added the following to the default cordova project config.xml and

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-27 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135566988 Added comments. I'll try to put together a sample that shows the issue. The ones I am using are not available on NPM. --- If your project is set up f

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-26 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-lib/pull/288 CB-9560 Issue using plugin restore for plugins with common dependencies Similar change to CB-9278. This change makes it so only one plugin is restored at a time. You can merge this

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117386712 Code does work. I have been running my plugin tests with this change. For the Cordova mobile spec, I don't have an iOS device

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-06-30 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117172177 Just updating the Jasmine files. No custom changes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110080565 Thanks. I filled out a Apache CLA back in January and got confirmation from Apache Secretary Craig Russell. I have done a pull request in the past for CB

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

2015-05-25 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13 CB-9071 Update test framework plugin to use Jasmine 2.3.4 Updating Jasmine version from 2.2.0 to 2.3.4. You can merge this pull request into a Git repository by running

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-05-21 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-lib/pull/224 CB-8993 Plugin restore ignores search path Passes provided searchpath to the plugin restore after adding a platform. Without this I would get errors sometimes about "loadLocalPl

[GitHub] cordova-cli pull request: CB-8993 Plugin restore ignores search pa...

2015-05-21 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-cli/pull/213 CB-8993 Plugin restore ignores search path Allows searchpath to be passed with the cordova prepare command. You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-test-framework pull request: CB-8528 Update test fr...

2015-02-23 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/11 CB-8528 Update test framework plugin to use Jasmine 2.2.0. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-android pull request: CB-8328 Add support for certificate ...

2015-01-19 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-android/pull/150 CB-8328 Add support for certificate challenges into Cordova Android https://issues.apache.org/jira/browse/CB-8328 Makes it possible for a plugin to handle certificate