[GitHub] cordova-plugin-geolocation issue #86: Add required=false to the uses-feature

2017-04-24 Thread ochakov
Github user ochakov commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/86 @patrickbussmann the workaround with the hook will create duplicate uses line in AndroidManifest.xml if you have another plugin declaring the same uses with required false

[GitHub] cordova-plugin-camera issue #245: Handle OutOfMemoryError exception when sca...

2017-04-24 Thread ochakov
Github user ochakov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/245 Yes, still happens on low RAM devices, e.g. Samsung S3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera pull request #245: Handle OutOfMemoryError exception w...

2016-12-20 Thread ochakov
GitHub user ochakov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/245 Handle OutOfMemoryError exception when scaling a picture ### Platforms affected Android ### What does this PR do? Handles OutOfMemoryError exception when

[GitHub] cordova-plugin-geolocation pull request #86: Add required=false to the uses-...

2016-12-19 Thread ochakov
GitHub user ochakov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/86 Add required=false to the uses-feature ### Platforms affected Android ### What does this PR do? Modifies plugin.xml to allow installation

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-02-09 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-181845807 @ianisted Use my version of the plugin https://github.com/ochakov/cordova-plugin-camera --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-01-17 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-172336151 @riknoll, I can't really invest more time in this bug. I am doing completely different things now. --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-01-04 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-168818980 @riknoll done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2015-12-05 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-162259724 ICLA has been filed and approved by Craig L Russell --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2015-12-02 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161412438 I have two questions then: 1. When you do not declare camera permission in the manifest, does it work on older Android versions? 2. When you do

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2015-12-02 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423854 riknoll, Sounds alright. I would also check camera and storage permissions separately in case someone will approve one of them, but deny the other

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2015-12-02 Thread ochakov
Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161470590 Added both fixes to this PR Camera permission will not be required unless android.permission.CAMERA is set in the package. BTW, barcode scanner

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2015-12-01 Thread ochakov
GitHub user ochakov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/142 Fix missing CAMERA permission for Android M Fixing a bug where for Android M new permissions model, only external storage permission was asked, while camera permission

[GitHub] cordova-plugin-geolocation pull request: Fix crash on deny permiss...

2015-12-01 Thread ochakov
GitHub user ochakov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/57 Fix crash on deny permission request on Android M On Android 6.0 when asking for permission to access location, answering Deny will cause application crash You can merge