[GitHub] cordova-docs issue #696: CB-12686 - Add docs for support in ...

2017-04-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/696 Dependents: #698 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-04-26 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r113513631 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,46 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-04-26 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r113512443 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,46 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-04-26 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r113513050 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,46 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-04-26 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r113513420 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -0,0 +1,46 @@ +--- +layout: post +author: +name: Audrey So +url: https

[GitHub] cordova-docs pull request #696: CB-12686 - Add docs for supp...

2017-04-26 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/696#discussion_r113506314 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -476,7 +476,7 @@ This tag installs resource files into your platform, and is similar to the same

[GitHub] cordova-ios issue #309: CB-8980: Ensure copied resource-files are cleaned

2017-04-25 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/309 This will go in cordova-ios@4.4.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request #696: CB-12686 - Add docs for supp...

2017-04-25 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/696#discussion_r113364011 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -470,6 +470,23 @@ Examples: ``` +## resource-file + +This tag

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-04-25 Thread Shazron
The PR for the Plugin Audit is originally here: https://github.com/cordova/cordova-discuss/pull/58 On Tue, Apr 25, 2017 at 6:55 PM, Shazron <shaz...@gmail.com> wrote: > This is the start of a conversation: > https://issues.apache.org/jira/browse/CB-12708 > > Take thes

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-04-25 Thread Shazron
at 6:55 PM, Shazron <shaz...@gmail.com> wrote: > This is the start of a conversation: > https://issues.apache.org/jira/browse/CB-12708 > > Take these two issues below into consideration: > > 1. Cordova's plugin audit sometime back: > https://github.com/stev

[GitHub] cordova-plugin-media pull request #132: CB-12542 - Can't record to a wav fil...

2017-04-25 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[CORE PLUGINS][DISCUSS] Roadmap 2017

2017-04-25 Thread Shazron
This is the start of a conversation: https://issues.apache.org/jira/browse/CB-12708 Take these two issues below into consideration: 1. Cordova's plugin audit sometime back:

[GitHub] cordova-docs issue #698: CB-12687 - cordova-ios@4.4.0 Blog Post

2017-04-25 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/698 Note the links are not live -- since they depend on #695 and #696 and pushing the updated docs live --- If your project is set up for it, you can reply to this email and have your reply

[BLOG POST][DRAFT] cordova-ios@4.4.0

2017-04-25 Thread Shazron
Please review: https://github.com/apache/cordova-docs/pull/698

[GitHub] cordova-docs pull request #698: CB-12687 - cordova-ios@4.4.0 Blog Post

2017-04-25 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/698 CB-12687 - cordova-ios@4.4.0 Blog Post ### What does this PR do? Blog post for cordova-ios@4.4.0 release ### Checklist - [X] [Reported an issue](http://cordova.apache.org

[CORE PLUGINS] Expansion of features needs to be discussed in dev@

2017-04-25 Thread Shazron
Resources are limited and we can barely keep up with all the core plugin work that needs to be done, so we have to have a process with dealing with desired features that community members send out as PRs. Firstly I want to acknowledge that external contributions are valued highly by the team, but

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-25 Thread Shazron
btw update your cordova-coho before verifying On Mon, Apr 24, 2017 at 11:22 PM, Shazron <shaz...@gmail.com> wrote: > Sweet!!! > > On Mon, Apr 24, 2017 at 10:56 PM, Alexander Sorokin (Akvelon) < > v-als...@microsoft.com.invalid> wrote: > >> By the way, we now do

Re: [Vote] 6.2.2 Android Release

2017-04-25 Thread Shazron
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Added the platform, built, and deployed to device (using both SDK tools v25 and v26) On Mon, Apr 24, 2017 at 11:12 PM,

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-25 Thread Shazron
udapp.net:8080/job/cordova-ios-commit/36/ > > -Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Saturday, April 22, 2017 3:46 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] cordova-ios@4.4.0 release > > Umm typo: > REMOVED: iOS 8 Support

[GitHub] cordova-docs pull request #696: CB-12686 - Add docs for supp...

2017-04-24 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/696 CB-12686 - Add docs for support in config.xml ### What does this PR do? Adds docs for config.xml support ### Checklist - [X] [Reported an issue](http

[GitHub] cordova-docs pull request #695: CB-12655 - Add docs for embed attribute of <...

2017-04-24 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/695 CB-12655 - Add docs for embed attribute of tag ### What does this PR do? Adds docs for the embed attribute of the tag (iOS only) ### Checklist - [X] [Reported an issue

[GitHub] cordova-docs issue #690: Cordova Screen Orientation Plugin Blog

2017-04-24 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/690 @maverickmishra response to the review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[VOTE] 4.4.0 iOS Release

2017-04-24 Thread Shazron
Please review and vote on this 4.4.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12687 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12687 The package

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-21 Thread Shazron
Umm typo: REMOVED: iOS 8 Support On Fri, Apr 21, 2017 at 5:27 PM, Shazron <shaz...@gmail.com> wrote: > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=162 > > cordova-ios@4.4.0 is feature complete. Vote thread upcoming. > > ## HIGHLIGHTS > > NEW:

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-21 Thread Shazron
last week and busy > now catching up on work stuff :( > It should be pretty quick, involving only changes to the prepare.js > file, probably very similar to the implementation on Android: > https://github.com/apache/cordova-android/pull/321 > > On 12 April 2017 at 16:11, Shazro

Re: [DISCUSS] Cordova@7 Release

2017-04-21 Thread Shazron
Yes! I'll get on https://issues.apache.org/jira/browse/CB-12655 for the release (its on the board) On Fri, Apr 21, 2017 at 4:49 PM, Jesse wrote: > Let's do it! > > > @purplecabbage > risingj.com > > On Fri, Apr 21, 2017 at 4:48 PM, Steven Gill >

[GitHub] cordova-ios pull request #310: CB-12009 - target attribute i...

2017-04-21 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/310 CB-12009 - target attribute ignored on iOS when installing a Cordova plugin ### Platforms affected self ### What does this PR do? Fix bug where `target` attribute

[GitHub] cordova-ios pull request #308: CB-8980 - fix target attribut...

2017-04-20 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/308 CB-8980 - fix target attribute in config.xml ### Platforms affected self ### What does this PR do? Fix the target attribute not working properly for tag

[GitHub] cordova-ios issue #307: CB-12673 - ios platform does not build on Xcode 8.3....

2017-04-19 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/307 Not sure why CI is failing on an unrelated unit-test, it passes locally. Investigating. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request #694: CB-12514 - docs for Carthage support.

2017-04-19 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/694 CB-12514 - docs for Carthage support. Fixed up some old Xcode references in corresponding docs as well. ### Platforms affected iOS ### What does this PR do

[GitHub] cordova-ios pull request #307: CB-12673 - ios platform does not build on Xco...

2017-04-19 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/307 CB-12673 - ios platform does not build on Xcode 8.3.2 ### Platforms affected self ### What does this PR do? Fixes the CordovaLib.xcodeproj reference in the template

[ADVISORY] ios platform does not build with Xcode 8.3.2

2017-04-19 Thread Shazron
Don't upgrade yet if you don't need to. Full details here: https://issues.apache.org/jira/browse/CB-12673 A fix is underway.

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-04-18 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/321 Leaving some notes here for future reference (in case there are bugs): 1. Firstly `cleanFileResources` is called, but effectively useless during runtime, even if you have a `` tag

[GitHub] cordova-ios issue #305: CB-8980 - Support tag in config.xml ...

2017-04-18 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/305 Node 6 only failure, node 4 is fine. Debugging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 As of right now, you can use the latest `cordova nightly` and `cordova-ios nightly` to test this feature. ``` npm install -g cordova@nightly cordova platform add ios@nightly

[GitHub] cordova-ios pull request #305: CB-8980 - Support tag in conf...

2017-04-17 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-ios/pull/305 CB-8980 - Support tag in config.xml in iOS platform ### Platforms affected self ### What does this PR do? Support `` tag in config.xml in iOS platform

[GitHub] cordova-ios pull request #305: CB-8980 - Support tag in conf...

2017-04-17 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #305: CB-8980 - Support tag in config.xml ...

2017-04-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/305 Bah, objc-tests but seems like it just died when running the Simulator tests, probably a timeout -- flaky. Locally the objc-tests are passing. Running it again by closing and opening the PR

[GitHub] cordova-ios pull request #305: CB-8980 - Support tag in conf...

2017-04-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/305 CB-8980 - Support tag in config.xml in iOS platform ### Platforms affected self ### What does this PR do? Support `` tag in config.xml in iOS platform

[GitHub] cordova-ios issue #301: CB-12617 : added engine strict for users with older ...

2017-04-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/301 @audreyso I got this warning now: ``` npm WARN engineStrict Per-package engineStrict (found in this package's package.json) npm WARN engineStrict won't be used in npm 3+. Use

[GitHub] cordova-ios pull request #304: CB-8980 - Support tag in conf...

2017-04-17 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #304: CB-8980 - Support tag in config.xml ...

2017-04-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/304 Closing this. Will open a new PR with cordova-common 2.0.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-cli pull request #274: CB-12662 - update cordova-common dependency t...

2017-04-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-cli/pull/274 CB-12662 - update cordova-common dependency to 2.0.2 ### Platforms affected All ### What does this PR do? Update cordova-common dependency to 2.0.2 ### What

[GitHub] cordova-lib pull request #543: CB-12662 - update cordova-common dependency t...

2017-04-17 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/543 CB-12662 - update cordova-common dependency to 2.0.2 ### Platforms affected All. ### What does this PR do? Update the cordova-common dep in cordova-lib and cordova

Re: [VOTE] cordova-common@2.0.2 Release

2017-04-17 Thread Shazron
The vote has now closed. The results are: Positive Binding Votes: 4 Steven Gill Jesse MacFadyen Audrey So Shazron Abdullah The vote has passed. On Mon, Apr 17, 2017 at 10:34 AM, Steven Gill <stevengil...@gmail.com> wrote: > I vote +1: > > * Ran coho verify-archive on posted b

[GitHub] cordova-ios issue #304: CB-8980 - Support tag in config.xml ...

2017-04-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/304 Waiting on https://issues.apache.org/jira/browse/CB-12662 cordova-common@2.0.2 release -- 1. revert all Travis tweaks 2. revert node-module changes (only update bundle cordova-common

[VOTE] cordova-common@2.0.2 Release

2017-04-14 Thread Shazron
Please review and vote on this cordova-common Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12662 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12262/ The

[DISCUSS] cordova-common@2.0.2 release

2017-04-14 Thread Shazron
I will start the vote tonight if there are no objections. Changes: Anything Mar 10 2017 and newer - https://github.com/apache/cordova-lib/commits/master/cordova-common This release is needed because it is blocking CB-8980 and thus cordova-ios@4.4.0

[GitHub] cordova-ios issue #304: CB-8980 - Support tag in config.xml ...

2017-04-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/304 CI failure due to: https://github.com/apache/cordova-ios/pull/299#issuecomment-290367527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-ios issue #304: CB-8980 - Support tag in config.xml ...

2017-04-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/304 `cordova clean` issues -- see my discussion in https://github.com/apache/cordova-android/pull/321 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-android pull request #321: CB-8978 Prepare copy resource-files from ...

2017-04-14 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/321#discussion_r111626815 --- Diff: bin/templates/cordova/lib/prepare.js --- @@ -401,6 +403,44 @@ function mapImageResources(rootDir, subDir, type, resourceName

[GitHub] cordova-android pull request #321: CB-8978 Prepare copy resource-files from ...

2017-04-14 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/321#discussion_r111626765 --- Diff: bin/templates/cordova/lib/prepare.js --- @@ -401,6 +403,44 @@ function mapImageResources(rootDir, subDir, type, resourceName

[GitHub] cordova-ios pull request #304: CB-8980 - Support tag in conf...

2017-04-13 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/304 CB-8980 - Support tag in config.xml in iOS platform ### Platforms affected self ### What does this PR do? Support `` tag in config.xml in iOS platform

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2017-04-13 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/468 @stevengill Can I assume support for this feature is out in the cordova@6.5.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-04-13 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/321 @dpogue @infil00p is this out in the latest cordova-android? Are there docs for this, or is it a copy-paste from plugin.xml? --- If your project is set up for it, you can reply

[GitHub] cordova-ios pull request #303: CB-10026 - Fix warnings in Objective-C tests

2017-04-13 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/303 CB-10026 - Fix warnings in Objective-C tests ### Platforms affected self. ### What does this PR do? Fix most warnings (non Photos framework related - those are in CB

[GitHub] cordova-ios pull request #302: CB-11895: openURL: is deprecated on iOS 10

2017-04-12 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/302#discussion_r111293110 --- Diff: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m --- @@ -115,11 +115,18 @@ + (BOOL

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-12 Thread Shazron
not just > images. > > Some plugins like the push plugin need this to avoid hooks for copying > FCM/GCM configuration files, icons and sounds. > > 2017-04-12 2:25 GMT+02:00 Shazron <shaz...@gmail.com>: > > > Anyone else need to wrap issues up for this releas

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-12 Thread Shazron
uot;resource-file" instead of > > "image" so it can be used with any file, like config files, and not just > > images. > > > > Some plugins like the push plugin need this to avoid hooks for copying > > FCM/GCM configuration files, icons and sounds

Re: wp8 support (cordova@7)

2017-04-12 Thread Shazron
+1 adieu WP8 On Wed, Apr 12, 2017 at 1:58 PM, Audrey So wrote: > Hi everyone! Just a quick update… we will be dropping support for windows > phone 8 (wp8) in cordova@7. > Here is the PR--> https://github.com/apache/cordova-lib/pull/539/commits. > If you have any questions or

Re: Publish to npm registry

2017-04-11 Thread Shazron
t like apache wants us to and the publish it to npm. Slower release cycle then the normal open source development but we have caught issues our CI missed with releases during the vote process. Let us know if you have more questions around npm. On Apr 11, 2017 5:39 PM, "Shazron" <shaz.

Re: Publish to npm registry

2017-04-11 Thread Shazron
so on. > > Cheers > Niclas > > > > On Wed, Apr 12, 2017 at 8:23 AM, Shazron <shaz...@gmail.com> wrote: > >> Confusing, sorry: "If you are not logged in, it will tell you to login >> with your npm account" >> >> On Tue, Apr 11, 2017 at 5:2

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-11 Thread Shazron
> > ~ Kerri > > > On Mar 1, 2017, at 14:25, Shazron <shaz...@gmail.com> wrote: > > > > Board: > > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=162 > > > > In-Progress issues are ones that definitely will get in. > > The ot

Re: Publish to npm registry

2017-04-11 Thread Shazron
Confusing, sorry: "If you are not logged in, it will tell you to login with your npm account" On Tue, Apr 11, 2017 at 5:22 PM, Shazron <shaz...@gmail.com> wrote: > Hi, > With this as the current working directory: https://github.com/ > apache/polygene-java/tree/develop

Re: Publish to npm registry

2017-04-11 Thread Shazron
Hi, With this as the current working directory: https://github.com/apache/polygene-java/tree/develop/tools/generator-polygene Run ``` npm publish ``` If you don't have an npm account while you are logged in, it will tell you to. More info: "npm publish --help" On Tue, Apr 11, 2017 at 5:07 PM,

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 I think this PR is good to go, I will squash and merge it in shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 @bhariharan the log seemed to loop. here it is: ``` objc[5175]: Class CDVViewController is implemented in both /private/var/containers/Bundle/Application/26EC3944-705D-4325-A5C3

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 For others to test the `embed` attribute for framework tag, you need the latest `cordova-common` module in your Cordova CLI: ```bash git clone https://github.com/apache/cordova-lib.git

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-11 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Just tested with a simple framework I created, works ok: https://github.com/shazron/cordova-plugin-hello-world-framework --- If your project is set up for it, you can reply to this email

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-10 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Updated my fork of your plugin and re-tested, all dynamic frameworks are loaded, but there are runtime errors (duplicate symbols) and config errors and such, which seems to me that the loading

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-10 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Added some fixes (above) based on my testing of your plugin which I forked with my edits: https://github.com/shazron/SalesforceMobileSDK-CordovaPlugin#ios_framework Not complete yet

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-07 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Tested this with the master branch CLI that has this `cordova-common` change: https://github.com/apache/cordova-lib/pull/535 This change above will only be in cordova-cli@7.0.0

[GitHub] cordova-ios issue #301: CB-12617 : added engine strict for users with older ...

2017-04-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/301 `enginestrict` is useless without the corresponding `engines` key. We should add this to the PR as well: ``` "engines" : { "node" : ">=4&qu

[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...

2017-04-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/373 I did local testing on the sdk tools 26.0.1 and 25.2.3 (pre-tool-removal-mess), both built fine using CLI project creation+ build, and standalone project creation+build. --- If your

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-04 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Debugged this. Found a solution. 1. The `embed` option will only add the framework if the "Copy Files" phase (that has to be named "Embed Frameworks") exists.

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-04-01 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Just tested this, when `embed=true` is passed into node-xcode `pbxProject.addFramework` - the framework is not added to the Embedded Binaries section. --- If your project is set up

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-03-31 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 https://github.com/apache/cordova-lib/pull/535 has been integrated, so we can finish testing this PR soon. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib issue #535: CB-11233 - Support installing frameworks into 'Embed...

2017-03-31 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/535 e2e tests were failing because of the new cordova-android@6.2.0 release. We rolled back the `latest` tag to cordova-android@6.1.2 and re-tested locally, e2e tests pass now. I am re-running

[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...

2017-03-31 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...

2017-03-31 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-lib/pull/535 CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project ### Platforms affected iOS ### What does this PR do? Support

[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...

2017-03-31 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/534 Moved to https://github.com/apache/cordova-lib/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-31 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...

2017-03-31 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/534 Looks like the AppVeyor failure is node 6 only, which is suspicious and probably a hiccup: ``` 1) HooksRunner fire method plugin hooks Test 011 : should filter hook scripts from

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-03-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Just did a quick test of `` in a plugin with the platform changes in this PR, the embed attribute is not picked up. Thus, we definitely need the `cordova-common` changes in the CLI (coming

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do?

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-03-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 CI is all green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-03-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 I might be able to get away with it if I revert this change I think: https://github.com/apache/cordova-ios/pull/299/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R42 --- If your project is set up

[GitHub] cordova-ios issue #299: CB-11233 - Support installing frameworks into "Embed...

2017-03-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/299 Looks like my PluginInfo.js change did not stick and overridden by the CI running 'npm install'. Builds fine locally. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...

2017-03-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/534 Getting unrelated test error: ``` 1) non-core platform add and rm end-to-end --fetch Test 009 : should add and remove 3rd party platforms Message: Expected Error: /tmp/e2e

[GitHub] cordova-ios pull request #299: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/299 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do?

[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...

2017-03-30 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/534 CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project ### Platforms affected iOS ### What does this PR do?

Re: [DISCUSS] Cordova-Android 6.2.0 Release

2017-03-27 Thread Shazron
+1 On Mon, Mar 27, 2017 at 11:07 AM, Joe Bowser wrote: > OK, I got everything I wanted in the release in. It's relatively future > proof for the time being on Linux and Windows, and Alexander's last minute > fix was a good catch (although I'm not sure why an earlier check

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

2017-03-25 Thread Shazron
let this stew a bit for discussion and won't move forward just yet. On Fri, Mar 24, 2017 at 12:46 AM, Corinne <corinnekr...@gmail.com> wrote: > > > Sent from my iPhone > > > On 24 Mar 2017, at 01:11, Shazron <shaz...@apache.org> wrote: > > > > Yes for p

[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...

2017-03-24 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/399 @robertoandrade I want to get this in, any word? If not I can just fork your branch and do the edits needed --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request #489: CB-11811 - Updated travis settings for CocoaP...

2017-03-24 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Plugin search is broken

2017-03-24 Thread Shazron
e plugin search live? > I found variations on it, but not sure I ever came across the canonical > version. > > ~ Kerri > > > On Mar 23, 2017, at 16:04, Shazron <shaz...@apache.org> wrote: > > > > I'm going to assume by lazy consensus that moving off npmsearch

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

2017-03-23 Thread Shazron
hu, Mar 23, 2017 at 4:29 PM, julio cesar sanchez <jcesarmob...@gmail.com > wrote: > No objection, but why Carthage and not CocoaPods? > > For the plugins we have to use plugman, right? > > 2017-03-23 22:07 GMT+01:00 Shazron <shaz...@apache.org>: > > > I'm goin

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

2017-03-23 Thread Shazron
I'm going to leave this open for the rest of this week, and if no concerns I will take that as lazy consensus and file an issue for changing this. On Tue, Mar 21, 2017 at 2:41 PM, Shazron <shaz...@apache.org> wrote: > ## DESCRIPTION > > Carthage is supported for embedding Cordov

<    1   2   3   4   5   6   7   8   9   10   >