[GitHub] cordova-plugin-wkwebview-engine pull request #13: CB-11074 - Ensure settings...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/13 CB-11074 - Ensure settings from config.xml are taken into consideration Take note of the disabled "testConfigurationWithMediaPlaybackAllowsAirPlay" unit

[GitHub] cordova-plugin-wkwebview-engine issue #8: CB-11074: Ensure settings from con...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 Please see #13, and let's continue discussion there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/236 @bhariharan if you could file a new issue at issues.cordova.io we'll try to fix this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: On vacation

Congrats Julio! Don't worry about anything -- we'll pick up where you left off. Enjoy! :) Shaz On Thu, Aug 4, 2016 at 3:17 AM, julio cesar sanchez wrote: > Hello all, > > Tomorrow I'm getting married and after that I will be on my honeymoon until > the 22th, so I won't

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/236 @bhariharan what cordova-ios version are you using? cordova-ios-4.1.0 fixes that loop problem. no, what you [linked to](https://github.com/apache/cordova-plugin-wkwebview-engine/blob

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 I'm afraid this PR needs to be re-based with master. I had to pull in other pull requests that probably touched part of the code you were working on. --- If your project is set up for it, you

[GitHub] cordova-plugin-contacts pull request #132: CB-11667 - Memory leak in CDVCont...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/132 CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef Related to https://github.com/apache/cordova-plugin-contacts/pull/35 You can merge this pull request into a Git

[GitHub] cordova-plugin-contacts issue #35: fix a nasty memory leak on ios

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/35 @lboekhorst see #132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 I have failing unit tests that do objectively verify that as others have shown, yes, we can't update the configuration dynamically (I've tried all sorts of clever runtime

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/232#discussion_r73437041 --- Diff: tests/CordovaLibTests/CDVWhitelistTests.m --- @@ -295,6 +295,37 @@ - (void)testAllowIntentsAndNavigations XCTAssertEqual

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/232#discussion_r73432421 --- Diff: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m --- @@ -95,23 +95,33

Re: [DISCUSS] cordova-plugin-media-capture video quality

+1 what Vladimir said On Mon, Aug 1, 2016 at 11:29 PM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I think I like option 2 more than others, assuming that we also accept > values between 0 and 1 as a medium quality. Then it won't break existing > behavior on Android and would

Re: [COMMUNITY RALLY] WKWebView localStorage will not work with file urls in iOS 10 unless...

This fix is not in iOS 10 beta 4. Hopefully beta 5 On Mon, Jul 25, 2016 at 4:18 PM, Shazron <shaz...@gmail.com> wrote: > In all the time I took to research and work on this, apparently Apple > removed the check 3 hours ago: > https://trac.webkit.org/changeset/203695 > > T

[GitHub] cordova-ios issue #239: CB-11648: Make CDVViewController send notifications

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/239 LGTM. Passes all local tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 There still need to be tests for the new code that is introduced in this repo (platform API etc), or perhaps I'm misunderstanding your last comment Steve --- If your project is set up

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/467 Did 77 files actually change or GH is not reporting this right? Seems an abnormally large number of files changed for tests. --- If your project is set up for it, you can reply to this email

Re: [Android] Road to 6.0.0

+1 On Tue, Jul 26, 2016 at 6:41 AM, Joe Bowser wrote: > Hey > > So, after the 5.2.2 release of Android, I think we should start merging the > API breaking changes that we have setup for 6.0.0 into mainline. If we > need to do another patch release of Cordova-Android, we

Re: Requesting more information about CB-11214 bug

Hi Sanjeewa, Please copy the repo steps and perhaps continue this discussion in the JIRA issue itself, where it can be tracked more effectively. Since Chris Armstrong is the reporter for the issue, he would get the email notifications when you commented on the issue.

Re: Cordova Screen orientation plugin

Vishal, which JIRA issue is this tracked at? On Wed, Jul 27, 2016 at 3:41 AM, Vishal Mishra wrote: > Tony, > > I am working on the cordova screen orientation plugin where I intend to > have just one javascript file instead of the dedicated javascript files for > each

Re: opinion about a bug fix

I would go with option 3, and keep the notification sending for backwards compat purposes. On Sun, Jul 17, 2016 at 12:02 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I'm looking into this issue https://issues.apache.org/jira/browse/CB-11178 > > The problem is on iOS 9 you can no

Re: Proof of Concept: Plugins as Android Modules

Bump - any eyeballs on Joe's issue? On Wed, Jul 13, 2016 at 4:53 AM, Joe Bowser wrote: > Hey > > Does anyone have a solution to the problem I'm facing with Gradle > dependencies. I can use some more eyeballs on this. > > Thanks > > Joe > > On Mon, Jun 27, 2016 at 1:57 PM,

Re: [Android] Dropping support for ICS and CB-8834

+1 On Tue, Jul 12, 2016 at 6:53 AM, julio cesar sanchez wrote: > +1 > > 2016-07-12 0:38 GMT+02:00 Joe Bowser : > > > Hey > > > > I'm looking through old issues, and I noticed that CB-8834 is still open > > because we still needed to support ICS, but

Re: Finding a bug for get familiar with code base

Hi Deshan, Try any of these "easyfix" labelled issues: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=131 On Sat, Jul 9, 2016 at 8:29 PM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > Hi, > > I'm a beginner to this cordova code base. It will be easy to get > familiar

Re: feedback on statusbar plugin ios

Thanks for all your work on this Julio - we should add the second option for the future. As for the magic number stuff, its fine for now to fix those issues since we have no alternative. On Fri, Jul 8, 2016 at 6:56 AM, julio cesar sanchez wrote: > The statusbar plugin on

Re: [DISCUSS] cordova-ios 4.2.1

+1 On Tuesday, July 26, 2016, Steven Gill wrote: > Similar to android, i want to update the bundled cordova-common version to > 1.4.0. > > Any issues? >

Re: [COMMUNITY RALLY] WKWebView localStorage will not work with file urls in iOS 10 unless...

In all the time I took to research and work on this, apparently Apple removed the check 3 hours ago: https://trac.webkit.org/changeset/203695 Thanks to Darryl Pogue for showing this to me! On Tue, Jul 26, 2016 at 6:54 AM, Shazron <shaz...@gmail.com> wrote: > ... we dupe this

[COMMUNITY RALLY] WKWebView localStorage will not work with file urls in iOS 10 unless...

... we dupe this Radar [1]. There is some related research and JIRA discussion here [2] I will outline the steps you need to do below. If we don't ask for this now, enabling this feature will probably go in iOS 11, just like loading file urls in WKWebView (support was non-existent in iOS 8,

[GitHub] cordova-plugin-wkwebview-engine issue #12: CB-10142, CB-10732: Allow opening...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/12 Unfortunately this is Apple Private API, and will get users apps rejected if this is used. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-ios issue #238: CB-11535 ios: fix bug with remove frameworks

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/238 hi @matrosovN can you add "CB-10361" to the PR title prefix as well? So it will now be: `CB-11535 CB-10361 ios: fix bug with remove frameworks` This is for tracki

[GitHub] cordova-plugins issue #23: CB-10956: Update the GCDWebServer

Github user shazron commented on the issue: https://github.com/apache/cordova-plugins/pull/23 Thanks! Can someone tell me what is the version of the GCDWebServer version we are bumping to? (for determining the plugin version bump) --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 since if the title is empty results in a bug with this new fix, please file another issue so it can be tracked and resolved there. --- If your project is set up for it, you

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69511105 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +93,29 @@ var handlers

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 No tests for this feature were available. Tests will need to be added before this can land. The existing tests pass now. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69505602 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var events

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69505429 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin, installOptions

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69505374 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +93,29 @@ var handlers

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69505064 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var events

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504887 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var events

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504867 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var events

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504824 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +93,29 @@ var handlers

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504742 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -66,17 +66,19 @@ var handlers = { install:function(obj, plugin

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504623 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin, installOptions

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504527 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, installOptions

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504555 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, installOptions

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69504477 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, installOptions

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Failing tests. Please run `npm install && npm test` in the repo first before committing. Looks like it fails the jshint tests. --- If your project is set up for it, you can reply to th

[GitHub] cordova-ios issue #233: CB-9371, CB-9703: Fix how prepare handles orientatio...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/233 Confirmed that Xcode uses the new defaults. Pulling this in and testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser issue #171: CB-11136: Fix OAuth by preventing In...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/171 Not sure what happened here with closing this PR, I assume you are withdrawing the contrib? --- If your project is set up for it, you can reply to this email and have your

[FYI] Contributors from Adobe will be away next week July 4-8 2016

If anyone was wondering why activity drops next week eh. It's Adobe's July break. Some are taking July 1st (tomorrow) off for Canada Day as well for Canadians' annual "Shed Your Winter Coatapalooza" and maple tree tapping refresher courses.

[GitHub] cordova-coho issue #128: CB-11484 Fix library vulnerability in nlf

Github user shazron commented on the issue: https://github.com/apache/cordova-coho/pull/128 Let's get this in, I'd like status.cordova.io to be all green (this is the last red issue) 💯 For those wondering, bithound.io found that those two deps were not used. --- If your

[GitHub] cordova-plugin-inappbrowser issue #94: CB-3360: Set custom inappbrowser user...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 @cjpearson can you rebase this? It can't be pulled in cleanly anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-network-information issue #41: fixed two potential memory lea...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/41 Note: we should update Reachability as well, there are some IPv6 stuff in the latest revision, or it points to better IPv6 support inherent. Not sure if we have the latest

[GitHub] cordova-plugin-network-information issue #41: fixed two potential memory lea...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/41 LGTM. These fixes are also in Apple's code as well: https://github.com/apache/cordova-plugin-network-information/pull/41 --- If your project is set up for it, you can

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 I'm creating failing unit tests for this first, I think we have passed the point where we can argue about the implementation, but we need objective verification: https

[GitHub] cordova-plugin-wkwebview-engine issue #8: CB-11074: Ensure settings from con...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8 I'm creating failing unit tests for this first, I think we have passed the point where we can argue about the implementation, but we need objective verification: https

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/116 Thanks for this PR. There's 3 issues with this PR: 1. It doesn't merge cleanly anymore - the commits should be rebased 2. An issue should be created

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/232 CB-11270 - Handle JavaScript onclick handler navigation You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-11270

Re: [DISCUSS] Buildbot deprecation

> > -Nikhil > > -Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Thursday, June 23, 2016 11:18 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Buildbot deprecation > > Thank you Vladimir and Alexander! > Looks great. >

Re: Cordova CLI Telemetry results

Thanks Parash! This is great info. What's surprising to me is the amount of Brazil users, close to China's numbers. Some gaps in users -- no users in Greenland, Svalbard, and four central African nations :) We'll reach them soon... OS X (30.8%) vs Windows (47.2%) On Mon, Jun 27, 2016 at 4:28

Re: [DISCUSS] Use of nsp (node security cli) finds first vulnerable library that we use

pache/cordova-coho/pull/128 > > > > > > > > > > > @purplecabbage > risingj.com > > On Sat, Jun 25, 2016 at 1:15 AM, Shazron <shaz...@apache.org> wrote: > > > I think it's the first [1]. > > > > This is in cordova-coho [2], fro

[DISCUSS] Use of nsp (node security cli) finds first vulnerable library that we use

I think it's the first [1]. This is in cordova-coho [2], from a test [3] that our former intern Vishal (now employee) added. I'm not sure if any other repos are using a nsp test besides coho. We should add this check to our other repos that use node libraries. Thoughts? [1]

[GitHub] cordova-ios issue #231: Fix Macos Japanese Filename Problem. (Change NFD pro...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/231 I believe this was only a problem with 4.1.1 and below. Please try with 4.2.0, just released today. I arrived at a similar fix: https://issues.apache.org/jira/browse/CB-11401

[GitHub] cordova-ios issue #229: Incorrect reference to UIWebView

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/229 With the release of cordova-ios-4.2.0 today which includes the commit above, I believe this already fixes your issue. Please close this PR, thanks. --- If your project is set up for it, you

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/260 @cjpearson unfortunately this patch can't be applied since the code has changed. Can you re-work it based on the master code? Also, the code you are trying to patch is the default fallback

[GitHub] cordova-docs issue #615: CB-11445 added ios release blog post

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/615 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios issue #230: CB-11475 Ignore unsupported 60x60 icon

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/230 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: [DISCUSS] Buildbot deprecation

Thank you Vladimir and Alexander! Looks great. +1 to the deprecation. For future reference, this is how Jenkins is set up: https://github.com/apache/cordova-medic/blob/master/JENKINS.md On Thu, Jun 23, 2016 at 9:57 AM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > Also, we now

[GitHub] cordova-docs issue #615: CB-11445 added ios release blog post

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/615 We should add a note that doing a "platform update" will not reinstall your plugins if you didn't do a "--save" when you added them, or something to that effect. --- If

[GitHub] cordova-plugin-wkwebview-engine issue #10: rm outdated info about allowsInli...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/10 @revolunet any info for the above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [Vote] 4.2.0 iOS Release

I vote +1 * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully ran and built On Mon, Jun 20, 2016 at 3:52 PM, Steven Gill wrote: > Please review

[GitHub] cordova-plugin-media issue #102: CB-11430 Resolve CI failures on iOS platfor...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/102 With the new patch, all tests on multiple runs are passing for me. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 @pke thanks! Historical, and permissions granularity issues. Apache is working on it so we can use GH issues, but that's still a ways off (in testing phase). --- If your

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 @laidig it is not set in your root config.xml, but the platform's config.xml (under platforms/ios/projectname/config.xml) since the settings are only for the ios platform

[GitHub] cordova-plugin-media issue #102: CB-11430 Resolve CI failures on iOS platfor...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/102 Now I get media.spec.24 error when I test using your patch: ``` 1) cordova-plugin-media-tests.tests >> Media media.spec.24 playback rate should be set properly using s

[GitHub] cordova-plugin-media issue #102: CB-11430 Resolve CI failures on iOS platfor...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/102 @vladimir-kotikov I'm not sure I like the change in https://github.com/apache/cordova-plugin-media/commit/aff00cd00d01bb4d7da8db41e8f6d0eaa7669549 since the diff shows that the whole

Re: Create an Issue Collector to reduce friction in filing issues

> Food for thought: > - Make it very short with key fields (versions, platform?, plugin?, > device?, steps with sample code) > - Can we require captcha for anonymous? > - Can we offer auth with github? (At least give us some id) > > - Carlos Santana > @csantanapr > &

Create an Issue Collector to reduce friction in filing issues

https://issues.apache.org/jira/browse/CB-11454 Pro: We can get users to file an issue easily by pointing them to our form (which will not require a login). Con: Since it is an anonymous form, potential for spammers will increase. Thoughts?

Re: [Discuss] Why was device.name removed from the device-plugin?

Didn't know about the need for BT permission, in that case I would not be for it. Needing this permission is confusing for developers and their end users. I think this should start as an external plugin, and if anything changes with regards to our concerns, we can re-visit making it part of core.

Re: Contribute to improve Apache cordova

Welcome Akila! Check out the contribution guide [1] and let us know if you need any additional help in this regard. [1] http://cordova.apache.org/contribute/ On Sat, Jun 18, 2016 at 10:28 AM, Akila Wicky wrote: > I'm so passionate with Open source development and interested

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 Those settings are set by the CLI from the plugin.xml. They are explicitly put in the README to show what permissions are needed by the plugin. It might

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 That's great. I can squash when I merge. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-wkwebview-engine issue #10: rm outdated info about allowsInli...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/10 Can you clarify? It's been fixed in an iOS release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [Discuss] Why was device.name removed from the device-plugin?

you > > mentioned: The user can always change the name of her phone and there > knows > > its name and will recognize it in a list of devices. > > > > On Fri, Jun 17, 2016 at 9:23 PM, Shazron <shaz...@gmail.com> wrote: > > > >> Hi Philipp, > >> This was the

Re: Contribution for improve Cordova

Welcome! Check out the contribution guide [1] and let us know if you need any help in this regard. Also, please subscribe to this list by sending an email to dev-subscr...@cordova.apache.org [1] http://cordova.apache.org/contribute/ On Fri, Jun 17, 2016 at 3:43 AM, sanjeewa kumara

Re: [Discuss] Why was device.name removed from the device-plugin?

Hi Philipp, This was the rationale: https://lists.apache.org/thread.html/e3b0e5f87ba3929d5578308b25ee9a6af5b91177b94015878970fa8e@1352248856@%3Cdev.cordova.apache.org%3E On iOS, [UIDevice name] returns the name the user sets in iTunes for their device i.e. "Shazron's iPhone 4", and can change

[GitHub] cordova-ios issue #229: Incorrect reference to UIWebView

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/229 I agree about the CI failure. Check out this commit: https://github.com/apache/cordova-ios/commit/2e41e221d50dd00b832879cd3b4ced372f8be428 I think it fixes this problem -- although

Re: [Plugin: Geolocation] Wrong permission message displayed

I've deleted your 6 duplicates and left: https://issues.apache.org/jira/browse/CB-11433 On Tue, Jun 14, 2016 at 12:49 PM, Philipp Kursawe wrote: > I tried to post this to the issue tracker, but it would just spin the > spinner and never let met create the issue. > > > So

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

date that accompanies it: > > https://github.com/apache/cordova-docs/pull/610 > > > > Can you guys review the pull-requests (I don't have rights to merge it > > right now in Github) > > > > Thanks > > > > David > > > > On Wed, Jun

Re: [Plugin: Geolocation] Wrong permission message displayed

Hi, Please never post an issue here. Wait until the issue tracker is back up, Apache is having issues. On Tue, Jun 14, 2016 at 12:49 PM, Philipp Kursawe wrote: > I tried to post this to the issue tracker, but it would just spin the > spinner and never let met create the

Re: [DISCUSS] iOS release

USS] iOS release > > Hold on just a moment. Nikhil had a comment about the PR that I need to > investigate and possibly make a small change. It should be ready later > today. > > -Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Thursday, May 26,

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 Looks good, except that I would only log if it failed and you had to reload, since it might get verbose when a user app switches a lot. Wrap in a #define like so: https

Re: Apache Cordova Project Global Status Page

http://status.cordova.io points to it now On Mon, Jun 13, 2016 at 11:34 AM, Shazron <shaz...@gmail.com> wrote: > What this tells me is, for Core Plugins, everything under iOS and Android > are failing -- which is unlikely that *all* are failing, and more probably > the CI

Re: Apache Cordova Project Global Status Page

What this tells me is, for Core Plugins, everything under iOS and Android are failing -- which is unlikely that *all* are failing, and more probably the CI setup or script is failing. On Mon, Jun 13, 2016 at 11:29 AM, Shazron <shaz...@gmail.com> wrote: > https://github.com/cordova/cordo

Apache Cordova Project Global Status Page

https://github.com/cordova/cordova-status I added defunct platforms for completeness, maybe we should remove? Some plugins are missing any test badges, not sure if they are more "plugin tools" (last section). Some tools are missing tests - some have tests and no badge (cordova-common).

Re: Nightly build #37 for cordova has failed

Looks like trying to publish over an existing version: ""You cannot publish over the previously published version 6.2.1-dev." On Fri, Jun 10, 2016 at 7:53 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #37 for cordova has failed. > > Please check failure details on

Re: Nightly build #36 for cordova has succeeded!

I like how Jenkins is all happy <3 On Thu, Jun 9, 2016 at 7:54 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #36 for cordova has succeeded! > The latest nightly has been published and you can try it out with 'npm i > -g cordova@nightly' > > For details check build

[GitHub] cordova-plugin-file issue #184: CB-11407 (ios): Added extern keyword to cons...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-file/pull/184 Since the Cordova CI Build failure was for Android, and this change was for iOS, I would ignore the false positive. (seems to be a config problem? "ERROR: Step ‘Publish JUnit

Re: [DRAFT] Cordova Board Report for June 2016

Awesome. Sending. On Wed, Jun 8, 2016 at 7:32 PM, Kerri Shotts <kerrisho...@gmail.com> wrote: > LGTM > > ~ Kerri > > > > On Wed, Jun 8, 2016 at 6:30 PM -0500, "Shazron" <shaz...@gmail.com> wrote: > > > > > > > > > > >

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 Pull in when we bundle update to the released cordova-common that includes https://github.com/apache/cordova-lib/pull/453 --- If your project is set up for it, you can reply to this email

[DRAFT] Cordova Board Report for June 2016

https://github.com/cordova/apache-board-reports/blob/master/2016/2016-06.md Let me know of any edits, or anything I missed. I'm aiming to send this by EOD today or early tomorrow. Thanks!

<    5   6   7   8   9   10   11   12   13   14   >