Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Hey Everyone! So I decided to dig into this and wanted to summarize my findings. Please correct me if I'm wrong. 1) is a new tag that allows us to *merge* or *overwrite* elements in config files. it only supports editing *one* element per block of edit-config. If you need multiple edits, you

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I'm confused what's not being covered? The edit-config tag which can be used from either plugin.xml or config.xml should be able to add new tags into an xml document as well as edit existing tags/attributes in an xml document. Simon Mac Donald http://hi.im/simonmacdonald On Fri, Sep 2, 2016 at

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Reviving this thread: So, it seems that a lot of us thought that the plugin.xml changes would fix our problem, in fact they haven't because of what Julio just mentioned. Right now a lot of the PRs that we're getting are to add extra settings. I'm tempted to just merge them since we still don't

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

That issue is about adding an attribute to an existing element of the AndroidManifest from plugin.xml, this topic is about adding the whole functionality of writing/editing the .xml/.plist files from config.xml instead of using a "silly" plugin 2016-07-21 23:24 GMT+02:00 Jesse

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

CB-11023 is what it was submitted under. afaik @purplecabbage risingj.com On Thu, Jul 21, 2016 at 2:22 PM, julio cesar sanchez wrote: > We still don't have an issue for this, right? > > I've been searching and found those three: > >

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

We still don't have an issue for this, right? I've been searching and found those three: https://issues.apache.org/jira/browse/CB-7232 (iOS) https://issues.apache.org/jira/browse/CB-11604 (Android) https://issues.apache.org/jira/browse/CB-10832 (Windows) 2016-04-29 17:13 GMT+02:00 Karen Tran

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Can I get someone to review my PR? https://github.com/apache/cordova-lib/pull/432 Thanks, Karen Tran On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Exactly. Multiple tags is also possible with this syntax. > > - > Best regards, Vladimir > >

RE: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Exactly. Multiple tags is also possible with this syntax. - Best regards, Vladimir -Original Message- From: Karen Tran [mailto:ktop...@gmail.com] Sent: Thursday, April 21, 2016 5:20 PM To: dev@cordova.apache.org Subject: Re: [Android] Need a solution to config.xml and

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

@Vladimir, in your suggestion, is this what you were going for? Being able to add multiple attributes to any direct children node of the parent? Regards, Karen Tran On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Another

RE: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Another proposal about syntax which allows to specify multiple attributes at once and does not require parsing attributes from plain text: Also I've took a quick look at the implementation and it looks good apart from one minor issue - when we're grafting attributes we probably do

RE: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Oh great! I have not taken a close look at the implementation itself. Perhaps you already had some of this in mind. As for the syntax for changing attributes, I would recommend something like this: Also, we should always prioritize config.xml edits over plugin.xml (giving the end developer

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Hi, I made an attempt at the functionality of being able to add attributes with the config-file tag. It's not completed yet, but I wanted to get some review before I proceed. With my changes, you can add an attribute through the config-file tag in plugin.xml when the plugin is added, and when the

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I would love to but I have a few other things to handle first. If someone else picks it up before I get to it then that's cool with me. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Apr 5, 2016 at 6:51 PM, Carlos Santana wrote: > Oh so it means you don't want to

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Haha, so you can merge all the waiting PR !! On Wed, Apr 6, 2016 at 12:51 AM, Carlos Santana wrote: > Oh so it means you don't want to work on the code :-p > > > On Tue, Apr 5, 2016 at 6:50 PM Simon MacDonald > wrote: > > > Thanks, I put a watch

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Oh so it means you don't want to work on the code :-p On Tue, Apr 5, 2016 at 6:50 PM Simon MacDonald wrote: > Thanks, I put a watch on that. > > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Tue, Apr 5, 2016 at 6:48 PM, Carlos Santana

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Thanks, I put a watch on that. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Apr 5, 2016 at 6:48 PM, Carlos Santana wrote: > Simon, I was not able to find a JIRA, I created a new JIRA [1] to enhance > plugin.xml to allow to add attributes > > [1]:

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Simon, I was not able to find a JIRA, I created a new JIRA [1] to enhance plugin.xml to allow to add attributes [1]: https://issues.apache.org/jira/browse/CB-11023 On Wed, Mar 23, 2016 at 11:30 AM Simon MacDonald wrote: > Seems like editing attributes in a

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Seems like editing attributes in a config-file is a wanted enhancement. Do we have a JIRA for it? Simon Mac Donald http://hi.im/simonmacdonald On Tue, Mar 22, 2016 at 5:09 PM, Carlos Santana wrote: > I agree to enable config.xml to be able to set or override using >

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I agree to enable config.xml to be able to set or override using config-file (i.e. any xml file including strings.xml) I also think that adding support in config.xml and plugin.xml to edit attributes is very helpful, this is exactly what we are doing for one of our plugin to add the attribute

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Yes, Simon, that's my opinion, and we should show the conficting values and the id of the plugin with the conficting values so the user knows he has to change the values on the config.xml or remove the plugin. But we still will have problems if the plugin uses a hook to write values instead of

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Maybe the configured values of the plugins are sometimes just default values that the user can override through the config.xml file. What about adding a flag indicating whether the value is overridable ? My 2 cents ... On Tue, Mar 22, 2016 at 3:02 PM, Simon MacDonald

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

So for Android's case you are thinking the order of precedence should be: config.xml plugin.xml AndroidManifest.xml // created by the "cordova" cli Then if config.xml overrides something that one of the plugins depends on then the app won't build. I can actually get behind that proposal if I'm

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I think, if there is a conflict between config.xml and plugin.xml we should not build. If we pick config.xml values, the plugins with conflicting values might not work, and if we pick the plugin.xml values, the app might not work the way the user wants. I think both options are bad, the user

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

When it comes to the AndroidManifest if config.xml and plugin.xml (possibly multiple plugin.xml's) disagree on the value of an attribute: - if the value is a boolean then it should default to 'false'. For instance if it is an attribute like supports small screens if one plugin sets it to false it

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

The disagreement could also like in a “preference” specifying a value, that is overwritten by this fragment. On 3/21/16, 11:28 PM, "Jesse" wrote: >I like having the same xml fragments in config.xml as we use in plugin.xml > > >parent="/manifest/application"> >

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I like having the same xml fragments in config.xml as we use in plugin.xml We will need to address precedence, as a plugin.xml and config.xml can disagree. > On Mar 21, 2016, at 12:46 PM, Shazron wrote: > > Continuing

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Continuing on Simon's point, we already have duplication of entries for preference tags in https://issues.apache.org/jira/browse/CB-9264 and a post-processing step does the removal of dupes. Not sure if this removal method would be adequate (as long as the desired tag to express is written to the

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I agree the config-file is the way to go but we need to go one step more and enable the changing of attributes in the config file instead of just adding lines to AndroidManifest.xml. For instance, the first bug CB-10894 talks about adding a preference for screen sizes. The default

RE: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I agree that config-file is the way to go. After an offline discussion with Nikhil, Parashu, and Jason, one question that came up was whether all of this native config stuff belongs in config.xml or should be separated out. One idea would be to define separate files for each configuration file

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Hello all, I agree with Julio that it is less confusing keeping the same mecanism that the one it already exists with the plugin.xml. Le 21 mars 2016 19:17, "julio cesar sanchez" a écrit : > I think we should add the config-file tag to the config.xml. > It's already

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

I think we should add the config-file tag to the config.xml. It's already implemented on the plugin.xml. It allows you to modify the AndroidManifest.xml or the info.plist when you install a plugin. But the number of plugins that just modify the AndroidManifest.xml or info.plist is increasing, I

RE: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Given that we are now using Gradle for builds, could these simply be gradle sub-projects that define an AndroidManifest.xml, that gets merged during Android build ? One way could be to support specifying "sub-projects" in config.xml, and these changes get picked up. Would it work for all cases

[Android] Need a solution to config.xml and AndroidManifest.xml feature requests

Hey So, if you've been paying attention to the JIRA, we've been getting slammed with a ton of feature requests/bugs regarding the Android Manifest where people want to add a 1:1 mapping between the two XML files. The thing is that it's getting out of control, and we need to find a better