RE: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-20 Thread Hu, Ningxin
implement Cordova APIs (and even wrap WebView engine itself) Thanks, -ningxin > -Original Message- > From: Leo Yang [mailto:[email protected]] > Sent: Friday, May 02, 2014 11:17 PM > To: [email protected] > Subject: Re: [Android] Not so fast....API changes in Cord

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-20 Thread Ian Clelland
On Tue, May 20, 2014 at 2:34 PM, Joe Bowser wrote: > On Tue, May 20, 2014 at 11:27 AM, Ian Clelland > wrote: > > Fair enough... (grumble grumble multiple inheritance...) I suppose that > > this was an experiment to see if we could somehow maintain compatibility > > with plugins that use the old

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-20 Thread Joe Bowser
On Tue, May 20, 2014 at 11:27 AM, Ian Clelland wrote: > Fair enough... (grumble grumble multiple inheritance...) I suppose that > this was an experiment to see if we could somehow maintain compatibility > with plugins that use the old public field. I was worried that there would > be issues with t

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-20 Thread Ian Clelland
Fair enough... (grumble grumble multiple inheritance...) I suppose that this was an experiment to see if we could somehow maintain compatibility with plugins that use the old public field. I was worried that there would be issues with the CordovaAndroidWebView not *being* a View anymore -- thanks f

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-20 Thread Joe Bowser
It may have passed the mobile spec tests, but it shat the bed on the changed JUnit tests. :( The fact is that the CordovaWebView has to be a view to support the users who use embedded webviews of some type. We're already breaking this with third party WebViews, but it's a minor breakage where som

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-16 Thread Michal Mocny
Chromium WebView would be quite the carrot to convince devs to accept change. With platform breakout looming, perhaps 4.0 isn't in the far future.. -Michal On Fri, May 16, 2014 at 4:43 PM, Ian Clelland wrote: > Ugh... so I finally managed to get back to this, and spent a day and a half > refac

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-16 Thread Ian Clelland
Ugh... so I finally managed to get back to this, and spent a day and a half refactoring the AndroidWebView class. I've pushed the results to a branch of cordova-android called "backwards_compat". (See https://github.com/apache/cordova-android/tree/backwards_compat) It passes all of the mobile spe

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-02 Thread Leo Yang
Since you talked about plugin so do you plan to introduce/merge xwalk extension mechanism to Cordova plugin mechanism? Thanks, Leo On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser wrote: > Hey > > So, once again, we're dealing with some major API changes once we > introduce pluggable webview. The

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-01 Thread Ian Clelland
I think I can get something up by the end of the day here (should still be the middle of your day :) ) I'll let you know when I have anything that you can evaluate. On Thu, May 1, 2014 at 11:39 AM, Joe Bowser wrote: > Sounds like a pretty serious change, but I think we should do it. > That bein

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-01 Thread Joe Bowser
Sounds like a pretty serious change, but I think we should do it. That being said, we're going to have to toss out all our existing JUnit tests. How soon can you get the changes into the branch? On Thu, May 1, 2014 at 8:02 AM, Ian Clelland wrote: > The only way I can see out of this mess is to *

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-01 Thread Ian Clelland
The only way I can see out of this mess is to *not* turn CordovaWebView into an interface, but instead make it an abstract base class. (I'm not sure yet whether it has to inherit from anything; maybe Joe's original refactorings mean that it can inherit only from Object, but I'm not sure that it doe

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-01 Thread Ian Clelland
On Thu, May 1, 2014 at 9:00 AM, Ian Clelland wrote: > On Wed, Apr 30, 2014 at 5:44 PM, Andrew Grieve wrote: > >> On Wed, Apr 30, 2014 at 5:35 PM, Joe Bowser wrote: >> >> > This is a perfect example of this XKCD: https://xkcd.com/1172/ >> > >> > On Wed, Apr 30, 2014 at 2:25 PM, Ian Clelland >> >

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-01 Thread Ian Clelland
On Wed, Apr 30, 2014 at 5:44 PM, Andrew Grieve wrote: > On Wed, Apr 30, 2014 at 5:35 PM, Joe Bowser wrote: > > > This is a perfect example of this XKCD: https://xkcd.com/1172/ > > > > On Wed, Apr 30, 2014 at 2:25 PM, Ian Clelland > > wrote: > > > On Wed, Apr 30, 2014 at 3:58 PM, Andrew Grieve

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Andrew Grieve
On Wed, Apr 30, 2014 at 5:35 PM, Joe Bowser wrote: > This is a perfect example of this XKCD: https://xkcd.com/1172/ > > On Wed, Apr 30, 2014 at 2:25 PM, Ian Clelland > wrote: > > On Wed, Apr 30, 2014 at 3:58 PM, Andrew Grieve > wrote: > > > >> Config.xml is not a very sane way to do things for

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Joe Bowser
This is a perfect example of this XKCD: https://xkcd.com/1172/ On Wed, Apr 30, 2014 at 2:25 PM, Ian Clelland wrote: > On Wed, Apr 30, 2014 at 3:58 PM, Andrew Grieve wrote: > >> Config.xml is not a very sane way to do things for the embedded webview >> case. E.g. you may want two webviews with di

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Ian Clelland
On Wed, Apr 30, 2014 at 3:58 PM, Andrew Grieve wrote: > Config.xml is not a very sane way to do things for the embedded webview > case. E.g. you may want two webviews with different configs. Config.java is > a singleton right now, and I think it would be much nicer as a parameter > you could give

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Andrew Grieve
Config.xml is not a very sane way to do things for the embedded webview case. E.g. you may want two webviews with different configs. Config.java is a singleton right now, and I think it would be much nicer as a parameter you could give to the WebView upon initialization & plugins should say: this.g

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Michal Mocny
On Wed, Apr 30, 2014 at 1:30 PM, Joe Bowser wrote: > On Wed, Apr 30, 2014 at 9:35 AM, Michal Mocny wrote: > > On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser wrote: > > > >> Hey > >> > >> So, once again, we're dealing with some major API changes once we > >> introduce pluggable webview. The first

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Joe Bowser
On Wed, Apr 30, 2014 at 9:35 AM, Michal Mocny wrote: > On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser wrote: > >> Hey >> >> So, once again, we're dealing with some major API changes once we >> introduce pluggable webview. The first change that was done for >> sanity was finally deprecating setProp

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Michal Mocny
On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser wrote: > Hey > > So, once again, we're dealing with some major API changes once we > introduce pluggable webview. The first change that was done for > sanity was finally deprecating setProperty. This was slated to be > removed by 3.5 or in six months

[Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-04-30 Thread Joe Bowser
Hey So, once again, we're dealing with some major API changes once we introduce pluggable webview. The first change that was done for sanity was finally deprecating setProperty. This was slated to be removed by 3.5 or in six months from the deprecation date, but we kept it in too long. While I