Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Shouldn't that be just pinned versions in package.json ? Can you share the install issues you had. I can compare and adjust quickly with a couple LXD containers. On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana wrote: > We should check into git repo node_modules > while

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

We should check into git repo node_modules while recreating the archive I saw differences, I think this was due to the npm version I used. But adding from git is broken, since git doesn't node_modules (i.e. shelljs, and others) But this should not stop the release since the dist archive contains

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

visual inspection looks good, and only touches ubuntu specific code. Go ahead and merge it. On Wed, Dec 2, 2015 at 6:56 AM David Barth wrote: > On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana > wrote: > > > David do we need to have the CB-9618

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill wrote: > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As > far > as I know, cordova-ubuntu should work the same with cordova@4.x and > cordova@5.x. The platform API changes aren't necessary to work with

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. We need one other committer to give a +1 so I can wrapnit up and publish On Dec 2, 2015 10:47 AM, "David Barth" wrote: > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill >

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana wrote: > David do we need to have the CB-9618 fix in cordova-lib before continuing > vote? > Not strictly speaking. You can manage to prep, build and run an app on Ubuntu if you add some symlinks or fake icon file to pass the

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As far as I know, cordova-ubuntu should work the same with cordova@4.x and cordova@5.x. The platform API changes aren't necessary to work with cordova@5.x We probably won't do a update to cordova@4.x unless a security concern

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Re-doing a round of testing right now. But, to be frank that icon fix in cordova-lib is quite needed, otherwise the icon "errors" make it unnecessarily complicated to prepare a project for building. ie https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618 At the very least I wanted

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

David do we need to have the CB-9618 fix in cordova-lib before continuing vote? If that so, do you think you have PR ready soon to review and get into master to be able to have a cli that support new ubuntu 4.3.1 On Tue, Dec 1, 2015 at 4:02 PM Steven Gill wrote: > Which

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

bump. Vote thread is going and needs two votes. David can you test it with master cli and confirm it is all working? On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill wrote: > Starting the vote for this > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Starting the vote for this On Tue, Nov 17, 2015 at 9:31 AM, David Barth wrote: > Hey, > > I would like to update the 4.x series of cordova-ubuntu with a couple of > fixes, and make it the last in the series supporting the cordova-cli 4.3.1 > branch as well > >- Cb

[DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Hey, I would like to update the 4.x series of cordova-ubuntu with a couple of fixes, and make it the last in the series supporting the cordova-cli 4.3.1 branch as well - Cb 9868 - Should propose to install missing Ubuntu dependencies on platform add