Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-05-04 Thread Norman Breau
I think I agree with jcesarmobile on the migration part... But I understand the problem of maintaining data in web storage containers, I've gone through this path when trying to migrate away from crosswalk. Personally, I've moved away from relying on web storage containers to store any data

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-05-04 Thread Niklas Merz
While working on this PR I got an idea for a migration strategy I just wanted to share here. Someone could build a plugin that handles the migration of web storage (Localstorage, IndexedDB etc). The app developer needs to set the new AndroidInsecureFileModeEnabled preference to true. The app

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-05-03 Thread Niklas Merz
Hi again, Thank you all for your feedback. > A lot of Cordova users will never enable this feature if it is an opt- in feature. This is a very good reason for me as well. I created a PR which introduces a preference to make the WebViewAssetLoader opt-out: https://github.com/apache/cordova-

RE: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-29 Thread Pieter Van Poyer
Hey I have to agree with Bryan and Julio. Make it opt-out with a next major release. That's my prefered option. A lot of Cordova users will never enable this feature if it is an opt-in feature. And yes it would be great if someone did already have some guidelines about data migration. Kind

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-28 Thread Niklas Apache
I would agree with Bryan and Julio that we should use the opportunity of this breaking release to move the defaults to current Android best practices and remove deprecated settings. I just started a PR [1] that introduces a preference to allow the use file URLs with this release. This means the

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-27 Thread julio cesar sanchez
My understanding is that file urls can technically continue working, but the defaults changed and some settings need to be enabled, and some of them are now deprecated and will stop working at some point in the future. I think defaulting to the old behavior is ok when doing minor releases (not

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-27 Thread Darryl Pogue
To counter a bit, all of my apps are using the standard Cordova Android WebView, and store all their data in the browser's indexedDB. I've had no issues with file URLs (although I expect that will change with API 30 enforcement). Losing data in an app update is unacceptable, and for many apps it

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-27 Thread Bryan Ellis
I also agree. I think we should move forward with these changes and use the WebViewAssetLoader by default. If must, we could write a blog post explaining how to use Norman's plugin for data migration. But I do not know if the plugin is complete to cover all data sources and fits this case. I

Re: [DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-27 Thread julio cesar sanchez
I would vote for defaulting to WebViewAssetLoader but still allow using file:// from a config.xml preference for the people that are not ready to move on. But on cordova-ios 6 I think we ended up defaulting to file:// and use the schemes only as opt-in. About migrating data, I don't think that's

[DISCUSS] Moving forward with the WebView on AndroidX and cordova-android 10

2021-04-27 Thread Niklas Apache
Hey folks, we recently merged a PR [1] which significantly changes how cordova- android loads web content in the webview and now need to decide how to move proceed. Google introduced the WebViewAssetLoader to make it possible to use web content from a standard http(s) scheme instead of file:.