The -nightly version is automatically published from master.
The references to user documents directory is indeed weird. This is an
artifact of how coho works. I hope we can fix this in the next major
release.
On Mon, Sep 17, 2018 at 5:22 AM Oliver Salzburg
wrote:
>
> What kind of verification is
What kind of verification is expected for these types of changes?
#285 only adds a license header. That looks pretty safe to me.
#287 I have a hard time seeing any relevant changes either. The
references to C:/Users/brodybits/Documents seem weird.
#281 seems to be the only relevant change at a
Thanks Julio.
Considering that this is a *patch* release, issued to resolve a few
issues, I would really favor a quick review from a couple
cordova-windows experts to ensure that I didn't break anything major.
Changes are from the following PRs:
* https://github.com/apache/cordova-windows/pull/28
Just a reminder that any discussion about a release should be done on the
discuss thread and not on the vote thread, even if the comment is to try to
get more votes for that release. Vote threads should only be used to vote,
and close the vote once it reaches the minimum number of votes.
So Brody
I'm still investigating this splashscreen issue -- not sure if
something broke, or I haven't defined something
(am n00b on Windows platform...)
On Wed, Aug 15, 2018 at 4:19 PM Jan Piotrowski wrote:
>
> > I had to set the MSBUILDDIR env var explicitly to C:\Program Files
> > (x86)\Microsoft Visual
> I had to set the MSBUILDDIR env var explicitly to C:\Program Files
> (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since
> our code fails to detect the MSBuild version installed with that,
> v15.8.
>
> The registry entry it checks still has MSBuild v4 from the .NET
> Framework --
I had also noticed this issue, with Visual Studio 2017, from our AppVeyor tests.
https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.1020
The AppVeyor configuration is set to accept the failures as a passing result if
using Visual Studio 2017.
I had been wanting to fix this so t
https://github.com/apache/cordova-windows/issues/274 which is not a
blocker IMO, but I'm not sure of the splash screen. Technically the
app builds and runs...
On Wed, Aug 15, 2018 at 1:40 PM Shazron wrote:
>
> You can debug what requirements it tries to detect for MSBUILD by running:
> cordova
You can debug what requirements it tries to detect for MSBUILD by running:
cordova requirements --verbose
On Wed, Aug 15, 2018 at 1:39 PM Shazron wrote:
>
> Repro steps:
>
> ```
> npm install -g cordova
> cordova create foo
> cd foo
> cordova platform add https://github.com/apache/cordova-wind
Repro steps:
```
npm install -g cordova
cordova create foo
cd foo
cordova platform add https://github.com/apache/cordova-windows#6.0.1
cordova run
```
Pre-requisites:
- Visual Studio 2017 Community installed with defaults
- Windows 10 SDK
- Set env var `MSBUILDDIR` to 'C:\Program Files
(x86)\Micr
Had trouble meeting the requirements to build, using VS 2017 Community edition
I had to set the MSBUILDDIR env var explicitly to C:\Program Files
(x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since
our code fails to detect the MSBuild version installed with that,
v15.8.
The registr
11 matches
Mail list logo
