[GitHub] cordova-android issue #344: CB-5968 (Android) - Missing the drawable-xxhdpi ...

2016-11-24 Thread rodriguesgm
Github user rodriguesgm commented on the issue: https://github.com/apache/cordova-android/pull/344 thanks @dpogue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-android issue #344: CB-5968 (Android) - Missing the drawable-xxhdpi ...

2016-11-24 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/344 That is unrelated, and probably an issue with the phonegap-plugin-push. Cordova-Android doesn't do anything related to notifications, or notification-specific icons. --- If your project

[GitHub] cordova-android issue #344: CB-5968 (Android) - Missing the drawable-xxhdpi ...

2016-11-24 Thread rodriguesgm
Github user rodriguesgm commented on the issue: https://github.com/apache/cordova-android/pull/344 I don't know if this is related with the issue I'm having, so maybe someone can help me. I'm using phonegap-plugin-push with Ionic2 and my custom icon for notifications are not working,

[GitHub] cordova-android issue #344: Cb 5968

2016-11-03 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-android/pull/344 Please update the title of this pr, per checklist item 2 **CB-5968 (android) Missing the drawable-xxhdpi folder** --- If your project is set up for it, you can reply to this email

[GitHub] cordova-android issue #344: Cb 5968

2016-10-28 Thread sterlingann
Github user sterlingann commented on the issue: https://github.com/apache/cordova-android/pull/344 Thanks @dpogue ! I updated the xxhdpi icon to 144 x 144. It looks to me like the splash screens are already 960x1600(xxhdpi) and 1280x1920(xxxhdpi). --- If your project is set up

[GitHub] cordova-android issue #344: Cb 5968

2016-10-28 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/344 I believe the xxhdpi icon should be 144×144, rather than 192×192. The xxhdpi splash screen is 960×1600. The xxxhdpi one is 1280×1920. --- If your project is set up for it, you

[GitHub] cordova-android issue #344: Cb 5968

2016-10-28 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/344 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/344?src=pr) is 35.21% (diff: 100%) > Merging