[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-15 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52292210 Our QA-team has now run through Samsung S2, S3, S4, S4, Note, Note II, HTC One and Nexus devices, and also ZTE Blade and HTC Desire HD (both running 2.2 and 2.3)

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-15 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52285259 The patch from you doesn't work. I've implemented my patch instead, and everything is peachy. I've sent this to our QA-team for testing. I'll report back with th

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-15 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52284281 I've tested your patch now, and I can't see that it solves this issue. I'll test more, and I'll also try my own patch later. --- If your project is set up for i

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-14 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52166091 I wasn't aware this wasn't in 3.5.1. This error is persistent, and should affect many users with Samsung devices (especially). I'll try to apply the patch and gi

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-13 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52079190 The fix was not in 3.5.1, you'll still need to try it from master or apply the patch to your copy to get the fix. --- If your project is set up for it, you can

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-08-13 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-52066802 I was away on vacation, so couldn't answer to your comments. I'm back at work, and we've updated Cordova on Android to 3.5.1, in response to the IBM Rese

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-11 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48759335 @agrieve Applying that patch to the 3.5.0 release fixes the issue completely. :) Y'all are amazing! --- If your project is set up for it, you can reply to

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48687118 I believe this issue is fixed on master. Have a look at the commit here: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=445ddd8 And t

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48660618 Hmm, sounds like you actually have a different issue. This isn't Samsung-only from what I saw (repro'd on LG Nexus 5). --- If your project is set up for it,

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657992 True, success() doesn't keep the callback, but for us it's not important. I changed the success() function to always keep callback, but that changed nothing for

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657793 I saw your comment, but reading from a mobile device, so I can't really test it out. My fix is exclusively for 3.3.x, there has been made lots if changes since t

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657215 BTW I also tried, as a workaround, to consistently execute `callbackContext.success()` or `failure()` for every callback (since I believe you said it might b

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48656575 I think I might be hitting the same issue as you ([comment added](https://issues.apache.org/jira/browse/CB-7104?focusedCommentId=14057854&page=com.atlassian.j

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-09 Thread hnilsen
GitHub user hnilsen opened a pull request: https://github.com/apache/cordova-android/pull/105 [CB-7104] Fix for the missing plugin message Please have a look at this. This might not be the cleanest fix for [CB-7104], but it does the job. It will toggle only when messages are in the