Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-204006738
We should be able to unit test the methods on the Whitelist object itself
without plugins. I also don't see the commit where the test is.
---
If your project
Github user ktop commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-201509250
@infil00p can you review again? see my previous comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ktop commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-200991279
I've added a test now.
Should we open another jira issue to update the Whitelist in the test
project?
It's still using the tags in config.xml and in
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-200517498
Can we have tests in the test project for this? It looks fine, but since
it's new functionality in cordova-android, adding a test would be good.
---
If your
Github user ktop commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-29843
@infil00p can you take a look at this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-android/pull/283
CB-10897 Refactor URI Parsing for Whitelist
Fix for CB-10897.
I moved out the code that parses the 'origin' from the whitelist to a
separate function so that it can also be used to p
