[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/285#issuecomment-202506848 Perhaps we can mock the Activity's request permissions method? I don't have a lot of experience writing JUnit tests for Android. --- If your project is set up

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/285#issuecomment-201966761 Can we somehow create a test for this? I don't know how this is testable, since I still don't know exactly how to use JUnit to test onActivityResult. --- If

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/285#issuecomment-201493604 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/285#discussion_r57489412 --- Diff: framework/src/org/apache/cordova/CallbackMap.java --- @@ -0,0 +1,65 @@ +/* + Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/285#discussion_r57487068 --- Diff: framework/src/org/apache/cordova/CallbackMap.java --- @@ -0,0 +1,65 @@ +/* + Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/285#discussion_r57485883 --- Diff: framework/src/org/apache/cordova/CallbackMap.java --- @@ -0,0 +1,65 @@ +/* + Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/285#discussion_r57485286 --- Diff: framework/src/org/apache/cordova/CallbackMap.java --- @@ -0,0 +1,65 @@ +/* + Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/285#discussion_r57485105 --- Diff: framework/src/org/apache/cordova/CallbackMap.java --- @@ -0,0 +1,65 @@ +/* + Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/285#issuecomment-201435318 @infil00p @jasongin please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-android/pull/285 CB-10963: Handle overlapping permission requests from plugins Adds support for overlapping permission requests from plugins (i.e. requests that are made while another request is still pendi