Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r62303417
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
va
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r62273198
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
var args =
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r62002478
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
va
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/303#issuecomment-216705549
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61976209
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -203,6 +203,11 @@ GradleBuilder.prototype.build = function(opts) {
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975714
--- Diff: bin/lib/check_reqs.js ---
@@ -238,13 +236,13 @@ module.exports.getAbsoluteAndroidCmd = function () {
return cmd.replace(/(\s)/g, '
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975678
--- Diff: bin/lib/check_reqs.js ---
@@ -254,18 +252,22 @@ module.exports.check_android_target =
function(valid_target) {
}
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/303
CB-11198 Skip android target sdk check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android faster
Alternativel
