[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-28 Thread delijati
Github user delijati commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-106200325 This solution is not sufficient for my needs i need to set the User-Agent from JS. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-06 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99489261 (and thanks!) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-06 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99489147 Merged. would be great if you could do another PR to update the docs:

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-06 Thread sinofool
Github user sinofool commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99629530 I will update the docs later. For both iOS and Android. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-06 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99633548 @sinofool There is already an issue for the iOS Doc CB-8960 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-05-05 Thread delijati
Github user delijati commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-99019365 Need this feature too. The old way in `onCreate` is not working anymore. ``` super.appView.getSettings().setUserAgentString(Your own agent string);

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-04-30 Thread staugaard
Github user staugaard commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-97878035 Yeah I also need this. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-04-13 Thread sinofool
Github user sinofool commented on the pull request: https://github.com/apache/cordova-android/pull/162#issuecomment-92611688 The Travis CL build failed due to new android-21 setup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-04-01 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/162#discussion_r27606969 --- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java --- @@ -199,7 +199,19 @@ private void initWebViewSettings() {

[GitHub] cordova-android pull request: CB-3360 Set custom User-Agent

2015-02-26 Thread sinofool
GitHub user sinofool opened a pull request: https://github.com/apache/cordova-android/pull/162 CB-3360 Set custom User-Agent Add two configurations to set user agent of webview. OverrideUserAgent to override UA to the setting value. AppendUserAgent to append the setting