Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-176044525
@vladimir-kotikov
I've restructured the fixes and have separated them in two commits.
Regarding the options I've considered your words and have
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-176068570
Verified and it seems to work fine now with all possible combinations of
`--` and other args (i tested with `--ant`, `--keystore` and `--alias` )
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-176136907
Wohoo! Good to see this is getting committed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-175576742
@Mitko-Kerezov, my bad, i missed you name in CLA list
Regarding the
> the usage of -- basically suggests "I want to stop passing options
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-175496415
@nikhilkh I've already filed the ICLA some time in 2015 and have already
contributed to cordova. (Can't find the email though but I have merged pull
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-175224220
This looks like a great fix to merge. @Mitko-Kerezov Did you get a chance
to file the ICLA?
---
If your project is set up for it, you can reply to this email
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-173500760
The second fix LGTM.
Regarding the first - looks like it breaks the scenario when
platform-specific options are passed behind `--` arguments
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-169964965
Ping @infil00p for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-android/pull/248#issuecomment-169372671
Ping @vladimir-kotikov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user Mitko-Kerezov opened a pull request:
https://github.com/apache/cordova-android/pull/248
Parse options correctly
Fix 1
Options have already passed through `nopt` module in the build file. Nopt
successfully parses all options which results in `argv.remain` being an
11 matches
Mail list logo
