Github user qwe2 commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-49001482
Being able to pass pre-instantiated plugins sounds like what I presonally
needed. Thanks.
---
If your project is set up for it, you can reply to this email and
Github user qwe2 closed the pull request at:
https://github.com/apache/cordova-android/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48938359
Change needs to be rebased I need to you confirm you've signed Apache's
ICLA http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48949233
I think this needs to be discussed more before merged, this seems to
potentially break stuff, and the benefit has not clearly been discussed. ( or
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48951400
init() has been recently deprecated. I'm not convinced that this is
solving a problem that we currently have. I'm not in favour of having
Factories just
Github user qwe2 commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48953658
The idea was that I needed a more modular way of creating plugins that I
had more control over than just relying on Cordova to instantiate arbitrary
classes with
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48955669
Thanks István,
I think what I was missing in your pull-request and problem description, is
how your plugin uses the factory to do something that it
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48958012
I recommend you continue to use a parameter-less constructor and provide
some other interface for setting values in another plugin. You are destined
for
Github user qwe2 commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48957070
The simplest example that comes to mind would be the need to be able to
pass additional parameters to a custom set of plugins or do something with them
at
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48985460
Sounds like maybe we abandon this PR.
Plugins have an initialize() method that you can override to do extra
constructor-time logic.
I've tweaked the API
GitHub user qwe2 opened a pull request:
https://github.com/apache/cordova-android/pull/97
Support for PluginFactory
Pull request based on this issue:
https://issues.apache.org/jira/browse/CB-6384
You can merge this pull request into a Git repository by running:
$ git pull
11 matches
Mail list logo
