[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184885794 Cool, seems like we've reached a consensus. Merging! --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user devgeeks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184856505 LGTM. That third layer of binding always seemed confusing. :+1: --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-183448308 @axemclion Can you check now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52271030 --- Diff: www/js/index.js --- @@ -19,22 +19,20 @@ var app = { // Application Constructor initialize: function() {

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user axemclion commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52264119 --- Diff: www/js/index.js --- @@ -19,22 +19,20 @@ var app = { // Application Constructor initialize: function() {

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181674386 @dblotsky yes. Definitely needs dev list approval. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181673845 Will this also be going out as an email to the dev@ list? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181659458 @axemclion Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181630866 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/15 CB-10522: Event binding in Hello World is misleading The current event binding in the Hello World example is slightly misleading. So, fixing it. @nikhilkh @dblotsky @rik