Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124158440
--- Diff: bin/template/www/cordova-sw.js ---
@@ -0,0 +1,23 @@
+
+// Note, these will be updated automatically at build time
+var
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124158393
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124158333
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124157183
--- Diff: cordova-js-src/confighelper.js ---
@@ -61,14 +61,9 @@ function readConfig(success, error) {
}
};
-
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124157156
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122787134
--- Diff: cordova-lib/cordova.js ---
@@ -1486,6 +1486,26 @@ module.exports = {
bootstrap: function() {
+var cache =
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122782989
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122785379
--- Diff: bin/template/www/cordova-sw.js ---
@@ -0,0 +1,23 @@
+
+// Note, these will be updated automatically at build time
+var
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122786300
--- Diff: bin/template/www/manifest.json ---
@@ -0,0 +1,21 @@
+{
+ "name": "My App",
+ "short_name":"My Ap",
+ "description":
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122780778
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122783962
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122786410
--- Diff: cordova-js-src/confighelper.js ---
@@ -61,14 +61,9 @@ function readConfig(success, error) {
}
};
-if
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r122782108
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-browser/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/32
Cb 12804
### Platforms affected
cordova-browser
### What does this PR do?
adds manifest.json support
### What testing has been done on this change?
added
15 matches
Mail list logo
