Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread Axel Nennker
I want to make clear that splash icons have nothing to do with CB-2606. Splash icons are handled in this issue: https://issues.apache.org/jira/browse/CB-3571 I have a PR for this https://github.com/apache/cordova-lib/pull/30 that implements this for Android. -Axel 2014-06-16 10:46 GMT+02:00 Axe

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread Axel Nennker
Launcher icons are not part of the app. Please do not put them into www. Put them into project_dir. One above www. Use in config.xml and put : > Github user rohitagg28 commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issuecomment-45202523 > > Hi > I am

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151794 Yes I have used these methods but these all suggest to replace the image into platforms folder that means to add manually but I want to add splashscreen without m

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151067 Pls take a look [here](https://github.com/apache/cordova-plugin-splashscreen/blob/master/doc/index.md#android-quirks_) and [here](http://docs.phonegap.com/en/3.0.0

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-13 Thread Axel Nennker
No Am 13.06.2014 09:13 schrieb "rohitagg28" : > Github user rohitagg28 commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issuecomment-45982246 > > Hi I want to ask that can I add custom splashscreen to my project > without making any changes in platforms fol

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-13 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45982246 Hi I want to ask that can I add custom splashscreen to my project without making any changes in platforms folder . --- If your project is set up for it, you can

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-12 Thread Axel Nennker
Rohit, please ask app developer questions on stackoverflow. http://stackoverflow.com/search?q=cordova+splash Issues and the dev list exist to discuss things related to cordova itself not how to build an app. Unless cordova fails to work as documented. http://cordova.apache.org/docs/en/3.5.0/config

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-12 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45851225 Hi I am integrating the icon for my app as using the trailing code but I am unable to add splashscreen to my app ,can you suggest anything.

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-06 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45308768 Thanks. The problem get solved by using the updated version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-05 Thread AxelNennker
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45215758 This is a 3.5 feature. Are you using the latest cordova version? I suggest to take further discussion to stackoverflow or contact my directly. --- If your p

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-05 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45214469 Yes I have follow the above procedure by putting res folder outside www and also follow the cordova documentation but still the icon doesn't change for my applica

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-05 Thread AxelNennker
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45211776 https://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-05 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45202523 Hi I am building the cordova application and I want change the default icon of the app . I am using android platform and I have put all my icons sizes into

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-29 Thread Sergey Grebnov (Akvelon)
@cordova.apache.org Subject: RE: [GitHub] cordova-cli pull request: CB-2606 add icon support Wanted to ping you folks on this PR - https://github.com/apache/cordova-cli/pull/166 -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Friday, April 18, 2014 12:05 AM To: dev Subject: Re

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-29 Thread AxelNennker
Github user AxelNennker closed the pull request at: https://github.com/apache/cordova-cli/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-29 Thread AxelNennker
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-41706635 Merged in as PR#166 https://github.com/apache/cordova-cli/pull/166 by Bryan. This closes CB-2606 --- If your project is set up for it, you can reply

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-29 Thread Parashuram Narasimhan (MS OPEN TECH)
Wanted to ping you folks on this PR - https://github.com/apache/cordova-cli/pull/166 -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Friday, April 18, 2014 12:05 AM To: dev Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support Thanks Sergey

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-18 Thread Axel Nennker
Thanks Sergey. I want cb-2606 to be fixed and would be happy if either PR is merged. I am sorry that I had not more time to cleanup the history in my PR. Thanks again. I hope that a committer takes the time to review and merge it now that ApacheCon is over. Axel Am 18.04.2014 00:16 schrieb "sgrebn

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-17 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-40769236 Hi @AxelNennker, I'm just trying to get this merged ASAP so I've opened a separate PR which constants the same changes but re-based and could be merged. Feel free t

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-04-06 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-39694176 Something goes wrong with this branch and the pull request. Our commits must be on top of apache/master head. Right now there is unrelated work here. As sim

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Sergey Grebnov (Akvelon)
Got it, thx! -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Thursday, March 27, 2014 10:59 PM To: dev Subject: RE: [GitHub] cordova-cli pull request: CB-2606 add icon support The icon in config.xml without width is used to specify a path in the predefined

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Axel Nennker
85542ce898317eb4f40 > > Thx! > Sergey > -Original Message- > From: Axel Nennker [mailto:ignisvul...@gmail.com] > Sent: Thursday, March 27, 2014 7:53 PM > To: dev > Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support > > any comments on t

RE: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Sergey Grebnov (Akvelon)
dova-cli/commit/8802945be42f89078bcd785542ce898317eb4f40 Thx! Sergey -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Thursday, March 27, 2014 7:53 PM To: dev Subject: Re: [GitHub] cordova-cli pull request: CB-2606 add icon support any comments on this method/implementation

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Axel Nennker
This pull request intentionally does not extend the w3c widget standard. There is no cdv:platform nor gap:platform nor any XML namespace used. Am 27.03.2014 18:01 schrieb "cmarcelk" : > Github user cmarcelk commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issu

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread cmarcelk
Github user cmarcelk commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-38831161 In a broad sense this looks reasonable. In the config.xml, why is there width and height attributes when using cdv:platform="android" and cdv:density="mdpi"

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-27 Thread Axel Nennker
any comments on this method/implementation? Wishes for an alternative implementation? I know that not all like the "guessing" part... Axel maybe this is liked by more of you?: config.xml // iconpath=some/path and iconname=icon.png would lead to this pseudocode implementation on Android: for

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-19 Thread AxelNennker
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-38080759 Re-implemented the "magic" for android. Typical sizes on Android are recognized and used. A default icon is copied to all res/drawable-*/ directories. A simp

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-16 Thread Axel Nennker
Rebased now. I will now repeat the changes on top of the new ConfigParser.js I still have the plan to avoid namespace fiddling and other XML related additions but I will probably not use too much of the magic stuff that I suggested earlier. Am 15.03.2014 13:48 schrieb "Axel Nennker" : > Will do t

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-15 Thread Axel Nennker
Will do that but it nicht take until tomorrow because I am traveling Axel Am 15.03.2014 12:17 schrieb "sgrebnov" : > Github user sgrebnov commented on the pull request: > > https://github.com/apache/cordova-cli/pull/126#issuecomment-37723271 > > @AxelNennker, could you please rebase your c

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-03-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-37723271 @AxelNennker, could you please rebase your code on top of the apache master? I don't see, for example, config_parser.js anymore. It was renamed plus there are new f