[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-31 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11128647 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : { +hostos : ['win

RE: [GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-29 Thread Jonathan Bond-Caron
On Fri Mar 28 03:16 PM, Jesse wrote: > 'process.platform' in node returns win32 for windows ( 32+64 ) 'process.arch' > returns x64 if it is 64bit > > Interesting didn't know. In case anyone is curious about this, refers to v8's 'win32' platform / win32 api https://github.com/joyent/node/blob/0

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11085455 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : { +hostos : ['win3

Re: [GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread Jesse
'process.platform' in node returns win32 for windows ( 32+64 ) 'process.arch' returns x64 if it is 64bit @purplecabbage risingj.com On Fri, Mar 28, 2014 at 12:00 PM, agrieve wrote: > Github user agrieve commented on a diff in the pull request: > > https://github.com/apache/cordova-cli/pul

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-28 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/146#discussion_r11080870 --- Diff: platforms.js --- @@ -39,12 +41,14 @@ module.exports = { version: '3.4.0' }, 'wp7' : { +hostos : ['win

[GitHub] cordova-cli pull request: CB-6322 Simplify platforms/platform code...

2014-03-20 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/146 CB-6322 Simplify platforms/platform code for platform specifics https://issues.apache.org/jira/browse/CB-6322 You can merge this pull request into a Git repository by running: $ git pull ht