Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-148376439
@nikhilkh, updated, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-148435203
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user daserge commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147620672
> We should remove this:
https://github.com/apache/cordova-cli/pull/224/files#diff-567859a4cc8b910de0454da79959bde6R53
- I know a lot of downstream tools currently
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/224#discussion_r41831327
--- Diff: src/logger.js ---
@@ -59,13 +58,12 @@ function formatError(error, isVerbose) {
logger.log = function (logLevel, message) {
if
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147750643
Yes, you are correct, for errors we could continue to having a prefix.
Removing the prefix from an existing message and adding a prefix might be fine.
---
If
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/224#discussion_r41881734
--- Diff: src/logger.js ---
@@ -45,44 +46,45 @@ function formatError(error, isVerbose) {
} else {
message = error.message;
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/224#discussion_r41882234
--- Diff: src/logger.js ---
@@ -45,44 +46,45 @@ function formatError(error, isVerbose) {
} else {
message = error.message;
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147800522
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shazron commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147543581
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147553471
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/224#discussion_r41816178
--- Diff: src/logger.js ---
@@ -59,13 +58,12 @@ function formatError(error, isVerbose) {
logger.log = function (logLevel, message) {
if
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147536916
:+1: :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-cli/pull/224
CB-9784 Remove CLI logger levels prefixes
`EventEmitter` usage provides info on an event level so the prefixing may
be superfluous taking into account we have coloring distinction for event
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147556117
We should remove this:
https://github.com/apache/cordova-cli/pull/224/files#diff-567859a4cc8b910de0454da79959bde6R53
- I know a lot of downstream tools currently
15 matches
Mail list logo
