Github user fardjad closed the pull request at:
https://github.com/apache/cordova-cli/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41329099
Thanks! Pulled in (will take a few minutes for this PR to auto-close as
apache mirrors repo).
---
If your project is set up for it, you can reply to this email and h
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41327534
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41327152
I'll fix that in a moment...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41327034
Shall I merge as is, or do you want to fix the ConfigParser?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41326953
Thats simply an implicit API description that calls to `getPreference` must
pass in lowercase names ;) (Okay, so its probably just a bug).
---
If your project is se
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41326597
@mmocny I updated the commit.
By the way the preference name matching in
[**ConfigParser.js**](https://github.com/apache/cordova-cli/blob/master/src/ConfigParser.
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41322753
I remember I saw an attribute in docs (probably older versions) that used
dashes, anyways I'll change the preference name to `AndroidLaunchMode`.
About the docs:
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41321690
Ah, I forgot, we will also need to update the docs (I can look at that if
you prefer not to).
---
If your project is set up for it, you can reply to this email and h
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41321647
The casing is actually insensitive, but the other preferences don't have
dashes, i.e. "WebViewBounce"
---
If your project is set up for it, you can reply to this ema
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41321384
Sure! But shouldn't we use small letters for the preference name (like
`android-launch-mode`)?
---
If your project is set up for it, you can reply to this email and
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41320706
Awesome. One last tiny request: may we change the name of the preference
to "AndroidLaunchMode"?
---
If your project is set up for it, you can reply to this email a
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41320392
I just added `` to
[defaults.xml](https://github.com/fardjad/cordova-android/commit/1b6298e6ec80c2810b336b21d4759f02a384f691).
Is that how it's supposed to be?
--
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41319318
Looks great. Will need to remember to update android's defaults.xml.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fardjad commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41318383
@mmocny Hello, I have amended the commit and submitted a pull request to
**cordova-android** repository.
---
If your project is set up for it, you can reply to this
Github user fardjad commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11925780
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11925400
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set l
Github user fardjad commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11924941
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11924705
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set l
Github user fardjad commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11924083
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user fardjad commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11923890
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user fardjad commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11923593
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11911345
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set l
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11911288
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set l
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11911266
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set l
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41180908
Thanks for the patch. I've created an issue for this:
https://issues.apache.org/jira/browse/CB-6501
---
If your project is set up for it, you can reply to t
26 matches
Mail list logo
