[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user stevengill commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112943481 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112934635 Looks good (well, apart from those blank lines you insist on adding at the beginning of blocks :smile:). --- If your project is set up for it, you can reply to t

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32667023 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r3248 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32665147 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32664301 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32664260 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32650376 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32650218 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-coho/pull/86 CB-9109 Switching to using .ratignores Switched to using a repository's `.ratignore` file instead of the `ratExcludes` property inside of coho. You can merge this pull request into a Git repo