Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41180911
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41204416
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41020487
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-coho/pull/95
CB-9739 Prevent coho from creating broken packages including CRLF on â¦
Windows
We may also need to add `.gitattributes` with
```
* text eol=lf
```
to force LF line
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41032650
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir =
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-coho/pull/95#issuecomment-145105221
+1 to `* text eol=lf` in `.gitattributes` - most commonly used tools on
Windows (other than notepad :smile:) should handle Unix line endings fine.
---
If your
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41080528
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41082335
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
