[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-10 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-182577611 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-182044901 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-182036432 @dblotsky done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/490#discussion_r52349972 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -131,82 +131,85 @@ platform. See [Icons and Splash Screens](images.html) for more information.

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-09 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/490#discussion_r52347236 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -131,82 +131,85 @@ platform. See [Icons and Splash Screens](images.html) for more information.

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-08 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/490#discussion_r52268466 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -131,82 +131,85 @@ platform. See [Icons and Splash Screens](images.html) for more information.

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/490#discussion_r52255295 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -131,82 +131,85 @@ platform. See [Icons and Splash Screens](images.html) for more information.

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/490#issuecomment-181500735 @omefire @dblotsky please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-docs pull request: CB-10206: Documenting uses-sdk attribut...

2016-02-05 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/490 CB-10206: Documenting uses-sdk attribute support in config.xml And stripped a lot of trailing whitespace. I recommend you append `?w=1` to the URL (lets you view diff without whitespace change