[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173687210 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173687010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173686307 Addressed comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173674096 Looks good, but I'm a bit confused with examples, which ones are examples ? which aren't ? --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173656844 The content looks good to me, but I had difficulty reading the document. It wasn't clear to me which parts of it are examples and which are the guidelines. The exa

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173651559 This looks great! Couple of comments - while your example illustrates this - your specification is not very precise: 1. Consider clarifying the position of 'Re

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-20 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/460 CB-10330 Adding style guide for xml references You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs raghav/xml Altern