[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-02 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/526#discussion_r54830128 --- Diff: www/static/js/index.js --- @@ -145,17 +145,46 @@ $(document).ready(function () { // Smooth scroll to anchor links $("a

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-02 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/526#discussion_r54826548 --- Diff: www/static/js/index.js --- @@ -145,17 +145,46 @@ $(document).ready(function () { // Smooth scroll to anchor links $("a[

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/526#issuecomment-191067882 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/526#discussion_r54667932 --- Diff: www/static/js/index.js --- @@ -145,17 +145,48 @@ $(document).ready(function () { // Smooth scroll to anchor links $("a

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/526#discussion_r54666977 --- Diff: www/static/js/index.js --- @@ -145,17 +145,48 @@ $(document).ready(function () { // Smooth scroll to anchor links $("a

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/526#discussion_r54665031 --- Diff: www/static/js/index.js --- @@ -145,17 +145,48 @@ $(document).ready(function () { // Smooth scroll to anchor links $("a

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-03-01 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/526#issuecomment-190880778 Cool! I'm assuming this fixes the camera docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-02-29 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/526#issuecomment-190585760 @riknoll @nikhilkh please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

2016-02-29 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/526 CB-10744 Fixing fragment link handling Adding support for name-based fragment anchors and anchors to IDs with special characters. You can merge this pull request into a Git repository by run