[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217042218 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217041794 Wohoo! 💥 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217040413 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-04 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-217001592 @jasongin @rakatyal @purplecabbage updated. iOS logo back to normal and new logo for OS X. ![new_logos_xml_2](https://cloud.githubusercontent.com/assets/1

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216668274 @jasongin maybe I can see about getting [this logo](http://www.apple.com/osx/) for OS X. Title text is added by docs.js [here](https://github.com/apache/c

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216667182 Diffing an svg file also sucks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-21788 Do the icons have title text? If so I can't find it in the code. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216665227 > The Apple logo is now used to indicate the OS X platform. This is confusing to me, given that I never think about using Cordova to develop apps for OS X, and

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216662778 Also note that this changes the iOS logo (see leftmost logo in attached image). The Apple logo is now used to indicate the OS X platform. The new iOS logo is sort

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216661665 @rakatyal @nikhilkh please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216661525 Here is what it looks like. The logos appear under the attribute name. ![new_logos_xml](https://cloud.githubusercontent.com/assets/13754588/14998002/775ed5

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

2016-05-03 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/593 CB-11196: Converting mark elements in docs to platform logos Changes the XML references to display platform logos rather than lists of highlighted platform names. Also adds new logos for iOS,