[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-04-19 Thread GustavoCostaW
Github user GustavoCostaW commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r60228374 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-22 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/544#issuecomment-200070628 Blargh! I need to hunt down the merge conflict before re-sending this pull request. I have no idea what changed on this file, though. --- If your project is set

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-22 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-docs/pull/544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/544#issuecomment-197065012 Minor comments, but otherwise looks pretty good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r56257602 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application Plugin

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r56257510 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application Plugin

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r56257379 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application Plugin

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r56257204 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application Plugin

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r56257158 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application Plugin

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-15 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/544#issuecomment-197026078 @riknoll Bump, I've updated the branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-08 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/544 CB-9393: Documenting how to embed a SystemWebView Redo of the pull request to update the SystemWebView documentation. You can merge this pull request into a Git repository by running: $

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-08 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/498#issuecomment-193884897 Redoing this pull request on a whole new branch, because this one-off is not going to work with all the changes @jcesarmobile is suggesting. --- If your projec

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-08 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-docs/pull/498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-17 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/498#issuecomment-185230674 I think this should be added too: `@Override public void onDestroy() { if (this.webInterface!=null) { this.webInter

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730805 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730771 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730759 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730825 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730788 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730740 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730725 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-12 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/498#discussion_r52730738 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,73 @@ components can communicate with each other, see Application P

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-11 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/498#issuecomment-183097926 Awesome! I'll give this a try when I get a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-02-11 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/498 CB-9393: Documenting how to embed a SystemWebView This is designed with Android Studio in mind. You can merge this pull request into a Git repository by running: $ git pull https://gith