Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219551255
LGTM!
Changes to CLI reference are effectively in this PR.
I'm OK with not making any changes related to my earlier comments as those
were separate PRs.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219550624
LGTM! Checked to make sure all changes were to `.md` files in 6.x and that
seems to be the case.
---
If your project is set up for it, you can reply to this email
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219547791
@omefire: This is just copying current dev to latest version on the docs
and hence you only see those changes. The privacy policy changes will take
effect when I
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219526115
However, I don't see the privacy policy changes:
```www/privacy/index.md```:
https://github.com/apache/cordova-docs/commit/0d5f185c45f11a46e3dc5b720e23d4b38a40779a
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219525124
Changes related to telemetry are definitely part of this snapshot.
Thanks Raghav!
---
If your project is set up for it, you can reply to this email and have yo
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63411548
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app
icons is to use `target` att
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63411414
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app
icons is to use `target` att
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63410912
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -19,17 +19,17 @@ license: >
title: Customize app icons
--- End diff --
'app
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219516481
@omefire , @riknoll : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/603
Snapshotting dev to 6.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav/snapshot
Alternatively you can re
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/562#issuecomment-198674853
@riknoll you're right, that PR didn't affect this. However in re-doing it I
found out that snapshotting didn't cover ToC files, and I fixed that. All's
well now,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/562#issuecomment-198590861
This is just moving the docs over right? In that case LGTM (as far as I can
review it)! Just make sure that #563 gets in before we publish
---
If your project is
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/562#issuecomment-198592236
Yep, it's just that. Will re-do this once #563 gets merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/562
Snapshotting dev to 6.x.
@nikhilkh @rakatyal @riknoll please give this a glance when you have a
moment.
You can merge this pull request into a Git repository by running:
$ git pull http
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/562#issuecomment-198603743
Do you have to redo it? That PR only affects index.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
17 matches
Mail list logo
