[GitHub] cordova-firefoxos pull request: delete foo file

2014-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-firefoxos pull request: delete foo file

2014-06-24 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-47009869 Looks good, thanks for working on this @marti1125! r+ @zalun, can you merge this? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-firefoxos pull request: delete foo file

2014-06-16 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46247504 Did some basic manual testing and looks good. r+ I added a comment about the header licenses to [the issue you created](https://github.com/marti1125/cor

[GitHub] cordova-firefoxos pull request: delete foo file

2014-06-13 Thread marti1125
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46077377 @rodms10 I made a test I didn't find any problem. and about Update Fix header licenses, I don't know, what I do? :( --- If your project is set up for it

[GitHub] cordova-firefoxos pull request: delete foo file

2014-06-13 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46071557 Glad it wasn't needed. I'll do some testing and let you know. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-firefoxos pull request: delete foo file

2014-06-12 Thread marti1125
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-firefoxos/pull/14 delete foo file You can merge this pull request into a Git repository by running: $ git pull https://github.com/marti1125/cordova-firefoxos CB-6832 Alternatively you can review an