Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@shazron All good now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue bah, same timeout error. Please do the close and re-open PR dance
again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue looks like a Simulator timeout. Can you close and re-open the PR to
trigger the CI again
@fredgalvao ditto what @dpogue said
---
If your project is set up for it, you can reply to
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@fredgalvao Personally, I think your idea is the right way to go in terms
of project structure, and should definitely be brought up for discussion on the
dev list (because it probably has
Github user fredgalvao commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Should my previous comment go into an issue dedicated to discussion? There
was no feedback on it, and it seems like there is a consensus into doing the
simple version, which imo doesn't
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@shazron This can go in to 4.4.1 now that cordova-common changes are merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user fredgalvao commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Is there any reason why this PR doesn't also export `CFBundleName` as the
result of the short name on config.xml? Follow me for a while:
According to [this page on the developer
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
I would like this in 4.3.0. Hopefully we can resolve
https://github.com/apache/cordova-lib/pull/453 for cordova-cli 6.4.0
---
If your project is set up for it, you can reply to this email and
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Rebased, but still blocked on the cordova-lib PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
This PR needs to be re-based.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/228
## [Current coverage][cc-pull] is **51.97%**
> Merging [#228][cc-pull] into [master][cc-base-branch] will increase
coverage by **0.16%**
```diff
@@ master
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Pull in when we bundle update to the released cordova-common that includes
https://github.com/apache/cordova-lib/pull/453
---
If your project is set up for it, you can reply to this email and
12 matches
Mail list logo
