Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Yay, green! And looks like the codecov reporting is fixed too ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/319
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master@8c77a0b`). [Click here to learn what
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Made some more changes, rebased, confirmed the unit tests now run on my
Windows 10 VM.
Sucks to be running tests conditionally but I'm not sure what other option
we have.
---
If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Props to @shazron for finding out there was an [integration test munging
the cordova-ios
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Ah, no, wait, I can repro if I run the full `npm test` - although those
files are not missing in my git tree (git status is empty). ð¤
---
If your project is set up for it, you can reply to
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Do you run a code-syncing background service like `realsync` or something?
Could that be doing it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
I'm trying `npm test` now instead of `npm run unit-tests`... maybe the e2e
tests are making changes to the git tree?
---
If your project is set up for it, you can reply to this email and have
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
I tried a fresh clone of my branch, `npm install --dev`, and `npm run
unit-tests`, and can't repro - runs fine on my end. Also worth noting that
those two files were not missing from my fresh
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Same error.
Did:
```
$ git checkout -- .
$ npm test
```
and it shows the same two deleted files.
---
If your project is set up for it, you can reply to this email and
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Hmm, the diff just shows that those files were moved?
If you `git checkout -- .` from the repo source, and rerun, do you get the
same behaviour?
---
If your project is set up for it,
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Uh oh ð interesting, I don't see that in my local setup.
I must have messed the history up, thanks for checking. I'll try with a
fresh clone myself and see if I can repro.
---
If
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/319
I cloned your fork and checked out the feature branch with all your commits.
Then:
```
$ npm install --dev
$ npm test
...
> cordova-ios@4.5.0-dev unit-tests
12 matches
Mail list logo
