[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/205#issuecomment-196207197 LGTM apart from one comment. @daserge, feel free to merge once that comment is addressed. --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/205#discussion_r55968611 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -202,7 +217,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) { */

[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/205 CB-10840 Use cordova-common.CordovaLogger in cordova-ios [Jira issue](https://issues.apache.org/jira/browse/CB-10840) You can merge this pull request into a Git repository by running: $ gi