[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-17 Thread samedii
Github user samedii closed the pull request at: https://github.com/apache/cordova-ios/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-59456499 Patched: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=9a3b108 You can close this PR now, thanks! --- If your project is set up for it, you ca

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-59332193 iCLA received (confirmed from ASF board@ svn) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-15 Thread samedii
Github user samedii commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-59273596 @shazron Yes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-59257782 @samedii did you email it or? Trying to get this into 3.7.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-14 Thread samedii
Github user samedii commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-59129706 @shazron Done, may take some time to go through though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-58952755 Thank you, looks good to me. I've searched and it appears that you haven't signed and submitted the Apache iCLA. Could you please do so?: http://www.apache.or

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-09-25 Thread samedii
GitHub user samedii opened a pull request: https://github.com/apache/cordova-ios/pull/108 Made isValidCallbackId threadsafe (Bug CB-7643) _callbackIdPattern was being changed on multiple threads which caused bad access errors https://issues.apache.org/jira/browse/CB-7643 You ca