[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/474 Ah, I see, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/474 I would like to use it in Phonegap, but also it seems like a useful method in general for dealing with Cordova projects. In the spirit of modularizing Cordova, it seems that Plugman would be a

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/474 @stevengill, @carynbear, no issues. Just curious where do you plan to use it outside of cordova-lib :) --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/474 @stevengill https://issues.apache.org/jira/browse/CB-11654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 @vladimir-kotikov any issues you see with us moving this from cordova-lib to cordova-common? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 Can you create a issue to remove the duplicate code + tests from cordova-lib. That can be a separate PR after cordova-common has been released. --- If your project is set up for it, you can

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/474 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/474?src=pr) is 80.66% (diff: 100%) > Merging [#474](https://codecov.io/gh/apache/cordova-lib/pull/474?src=pr) into [ma

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...

Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/474 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 Two things: 1) migrate the tests over and add them to this pr 2) add the apache license header comment to the top. You will notice every other file has this. Apache requirement.