[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/376#issuecomment-179500082 That's more like what we do for plugins (`cordova plugin ls`) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-lib/pull/376#issuecomment-179505519 @TimBarham @nikhilkh Agreed. Added formatting changes. Now the display will be like: Installed platforms: android 5.0.0 blackberry10

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/376#issuecomment-179503770 Yeah, and in fact, for consistency maybe "installed platforms" should also be separated by line breaks rather than commas: ``` Installed platforms:

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/376#issuecomment-179498720 I like the idea, but find the list is starting to get a bit confusing (to see the actual platform names. We need to make sure the platform names a very easy to

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/376#issuecomment-179511413 Looks great! Just one comment: I think just a couple of spaces would look better than a tab. Also, looks like there is a test that is sensitive to the

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-lib/pull/376#issuecomment-179407654 @dblotsky @nikhilkh @riknoll, @vladimir-kotikov Can you please review and merge this PR? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-10461: 'cordova platform ls' should l...

2016-02-03 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-lib/pull/376 CB-10461: 'cordova platform ls' should list the versions of platforms pinned Added version information to available platforms list. The output will be similar to: E:\projects\MyApp3>