[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

2016-02-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188710263 Thanks for advice, @TimBarham. Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

2016-02-24 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188545978 A simpler fix might be: since all we're looking for is the project's `id`, why not fall back on the main Cordova project's `config.xml` if we don't find a

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

2016-02-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188373756 Looking into failures... Another possible fix here - update `browser` platform rather than introducing additional complexity to platform adding

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

2016-02-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188327164 @TimBarham, could you take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

2016-02-24 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/398 CB-10662 Apply project config to platform before installing any plugins JIRA: [CB-10662](https://issues.apache.org/jira/browse/CB-10662) This change is needed because some