Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
What do you mean with "blank splash"? Splash without src?
If yes then I consider this illegal anyway.
I tested these cases on Android:
- no splash in config.xml
- one default splash. No density.
- all densities that exist in project.
- one density (xhdpi)
All worked.
Axel
PS: I am traveling and
Github user VVelda commented on the pull request:
https://github.com/apache/cordova-lib/pull/58#issuecomment-49475950
Now it works good with icons. But I have one question, you plain that your
changes removes splashcreen from project, if in config.xml is blank
tag, don't you?
But
fixed
2014-07-16 20:29 GMT+02:00 VVelda :
> Github user VVelda commented on the pull request:
>
> https://github.com/apache/cordova-lib/pull/58#issuecomment-49206968
>
> Changes deletes also icons and splashscreen in new blank project,
> which is bad. That should not to be done, until is
Github user VVelda commented on the pull request:
https://github.com/apache/cordova-lib/pull/58#issuecomment-49206968
Changes deletes also icons and splashscreen in new blank project, which is
bad. That should not to be done, until is icon or splashreen set in config.xml.
---
If your
Github user AxelNennker commented on the pull request:
https://github.com/apache/cordova-lib/pull/58#issuecomment-49157473
removed the extra lines. Strange they where there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Merge artefact.
Am 15.07.2014 03:46 schrieb "kamrik" :
> Github user kamrik commented on a diff in the pull request:
>
> https://github.com/apache/cordova-lib/pull/58#discussion_r14914123
>
> --- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
> @@ -42,6 +42,12 @@ module.e
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/58#discussion_r14914123
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -42,6 +42,12 @@ module.exports = function android_parser(project) {
this.androi
GitHub user AxelNennker opened a pull request:
https://github.com/apache/cordova-lib/pull/58
CB-7132: fix regression regarding default resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AxelNennker/cordova-lib master
Alte
