[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-09-08 Thread faenschi
Github user faenschi commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-138480152 Should this work with cordova 4.3.1? Nothing happens if I add android-activityName="MyName" to config.xml --- If your project is set up for it, you can reply to

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-08-27 Thread fredgalvao
Github user fredgalvao commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-13548 Shouldn't this be documented somewhere? It does not appear when I run `cordova help create` as a valid option. --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-02-27 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-76387512 @agrieve I've addressed your comments, could you take another look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-02-23 Thread cjpearson
Github user cjpearson commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/171#discussion_r25187402 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg, template_dir, opts) {

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-02-23 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/171#discussion_r25186284 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg, template_dir, opts) {

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-02-23 Thread cjpearson
Github user cjpearson commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/171#discussion_r25187454 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg, template_dir, opts) {

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-02-22 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-lib/pull/171 CB-7827: Allow user to specify android activity name This change adds an attribute to config.xml android-activityName that can be used to specify a custom activity name. If none is specified