Github user TimBarham closed the pull request at:
https://github.com/apache/cordova-lib/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stefangordon commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-74116684
Great stuff! Any pointers on how users can easily install this via NPM now?
I've only had success manually cloning the lib and cli repos and copying
correct bin
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-73999167
Thanks Jesse!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-73998473
Thanks Tim! This is now merged, the mirror is just slow to update. This
should close in a few minutes.
---
If your project is set up for it, you can reply to
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-73859774
Reviewed and tested, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/164
CB-8123 Plugin references can target specific windows platforms.
Adds support for `target`, `versions` and `arch` attributes on ``
and `` elements in the windows platform of plugin.xml. This
Github user TimBarham closed the pull request at:
https://github.com/apache/cordova-lib/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/155#issuecomment-73799000
I'll close this PR, and open a new, cleaned up PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/155#issuecomment-72117279
yeah, whichever approach is easier. Ultimately the test in this case is
invalid, but we don't want it appearing to break the build.
---
If your project is set
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/155#issuecomment-72114968
The tests use path.join(), but jsproj uses hard-coded backslashes (which is
reasonable, because normally it would only run on Windows). This problem is
showing up
ests previously).
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Thursday, January 29, 2015 12:04 PM
To: dev@cordova.apache.org
Subject: Re: [GitHub] cordova-lib pull request: CB-8123 Plugin references can
target spe...
The tests are only failing on Travis, which is ru
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/155#discussion_r23798529
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -0,0 +1,415 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) u
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/155#discussion_r23798388
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -0,0 +1,415 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) u
e.org
> Subject: [GitHub] cordova-lib pull request: CB-8123 Plugin references can
> target spe...
>
> Github user purplecabbage commented on the pull request:
>
> https://github.com/apache/cordova-lib/pull/155#issuecomment-71907847
>
> Very cool Tim!
>
>
> ---
]
Sent: Wednesday, January 28, 2015 12:18 PM
To: dev@cordova.apache.org
Subject: [GitHub] cordova-lib pull request: CB-8123 Plugin references can
target spe...
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/155#issuecomment-71907847
Very
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/155#issuecomment-71907847
Very cool Tim!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/155
CB-8123 Plugin references can target specific windows platforms.
Adds support for `target`, `versions` and `arch` attributes on ``
and `` elements in the windows platform of plugin.xml. This
17 matches
Mail list logo
