Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/162#discussion_r24500705
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -114,6 +116,22 @@ module.exports = function plugin(command, targets,
opts) {
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/162#issuecomment-73895354
lgtm save one nit. I think this behaviour is fine. Normal case will be to
use add --save anyways.
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
ah, I missed that lstatSync throws an exception for non-string args. I
suppose that's fine. Will merge!
On Wed, Feb 11, 2015 at 2:54 PM, omefire g...@git.apache.org wrote:
Github user omefire commented on a diff in the pull request:
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/162#issuecomment-73652050
I'm not aware of overall design of save/restore features, but code LGTM.
---
If your project is set up for it, you can reply to this email and have your
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/162#issuecomment-73641701
Well, if you review the document we all agreed on, it mentions this. Plus,
this feature is already in for platforms as well. I'm trying to mirror it :
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/162#issuecomment-73651273
@gorkem Also, this feature does not prevent the other one you mentionned.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/162
CB-8420 'cordova plugin add' should retrieve version, url or local folder
from config.xml if none is specified
CB-8420 'cordova plugin add' should retrieve version, url or local folder
from
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/162#issuecomment-73615544
@vladimir-kotikov, @agrieve and @gorkem , please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
