Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-154149943
Thanks. An update on this. I still want to get this in, but I will have to
postpone it unless someone else wants to take this up right now. With the
merge/rebase et
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151969906
Merged with cordova-lib/master.
Some tests fail but those failure were already present in the master branch.
---
If your project is set up for it, you can reply
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151667847
Try rebasing your branch with cordova-lib/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151667700
Unfortunately even though the tests pass -- there are too many conflicts
with the master branch.
---
If your project is set up for it, you can reply to this email
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151641072
Removed source files, and fixed merge issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151628253
Removed source files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151323347
11 failing tests:
```
Failures:
1) ios project handler installation of elements should call
into xcodeproj's addSourceFile appropriately whe
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151321669
Unfortunately I can't take this patch in as is.
The apple watch sample extension contains source files, which are not
Apache Licensed: projects/ios-apple-watch/
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-130869708
Hey @shazron - are you a good person to take a look at this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user sdesapio commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-118887096
@ogoguel You're definitely not the only one. I'm the one that posted that
bug report you're referring to. Waiting patiently.
---
If your project is set up for it,
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-118605960
Any update on that ? I'd like to avoid having to patch my cordova lib every
time, and I believe I am not the only one in that case (cf.
https://issues.apache.org/ji
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-109383817
Heh - I tried turning on the JSHint rule in `cordova-lib` just for kicks.
150 hits :).
---
If your project is set up for it, you can reply to this email and have
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-109379851
Great answer(s)! I was actually partially trolling @ligaz, our style-guide
does say be strict so it's all good.
Are there any side effects of the change to
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-109377681
It's certainly a common JavaScript recommendation to always use strict
equality / inequality operators so you don't accidentally get an invalid match
because of t
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-109357001
It is not better. Just trying to follow cordova-lib coding guidelines
requirements !
---
If your project is set up for it, you can reply to this email and have you
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-109353274
Why is it better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-109339921
Using !== instead of !=
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31824683
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,65 @@ module.exports = {
var xcBuildConfiguration =
xcode
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31790359
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,65 @@ module.exports = {
var xcBuildConfiguration =
xcodepr
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-108063507
Added SKIP_INSTALL to improve plist detection
Using node-xcode 0.7.0 (which includes the required modification)
---
If your project is set up for it, you can re
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31520090
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,76 @@ module.exports = {
var xcBuildConfiguration =
xcode
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31519205
--- Diff: cordova-lib/package.json ---
@@ -42,7 +42,7 @@
"underscore": "1.7.0",
"unorm": "1.3.3",
"valid-identifier": "0.0.1",
Github user galexandrov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31507207
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,76 @@ module.exports = {
var xcBuildConfiguration =
x
Github user galexandrov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31506402
--- Diff: cordova-lib/package.json ---
@@ -42,7 +42,7 @@
"underscore": "1.7.0",
"unorm": "1.3.3",
"valid-identifier": "0.0.
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-104160107
Replace the node-xcode package to support multiple target support
Now, plugman install the files/resources within the proper buildphase in
the Xcode Project
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-104068019
Fix Test And Make the Test More Reliable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-103903180
Looks like this pr breaks tests. Could you please address? (run "npm test")
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user ogoguel opened a pull request:
https://github.com/apache/cordova-lib/pull/219
CB-9033 : fix WatchKit support
Fixing plugin support while WatchKit has been added to an iOS project by
discard any list .plist file containing WKCompanionAppBundleIdentifier or
WKAppBundleIde
28 matches
Mail list logo
