[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-23 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104953745 Ok, updated with that functionality - if we don't find it installed, and we don't find it in the mapper list, then we add `cordova-plugin-` to the start (if it is

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104789786 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104788948 Yeah, I like that better. If we fail to find it in our typical id search, we then retry with the addition of `cordova-plugin-` Incidentally, internally

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104787089 Hmmm... Interesting point. I like the convenience of a short name, but I don't think it is worth the weirdness of adding a custom field to package.json just for t

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104784245 So, I discussed this a bit with Steve, and he brought up an interesting point. A stretch goal is to not have a plugin.xml file at all, and simply use pa

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104762109 Hah, yeah, I think that'd definitely be doable. I won't include it as part of this change, though. --- If your project is set up for it, you can reply to this em

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/225#issuecomment-104747950 Interesting, I like it. How about removing by path/url? Does it make sense having installed via `cordova plugin add ../myplugin/` that I could the

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-22 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/225 CB-9065 Allow removing plugins by short name. Adds logic to `plugin remove` to look up a plugin by "short name" if we don't find it by id. This means, for example, that you can use the follow