Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-115732883
@stevengill , Thanks for the fix !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-115464362
I ended up making a small fix with this btw. events.emit('warn', msg)
instead of 'warning'. warning was never displaying
---
If your project is set up for it, y
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-115461201
@stevengill, Thanks! could you also merge this related PR ? :
https://github.com/apache/cordova-cli/pull/214
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-115420444
Looks good. I'm merging it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-114946578
Tim, your suggestions have been taken into account, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/234#discussion_r32484031
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
}
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/234#discussion_r32483383
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
}
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-112177005
https://github.com/apache/cordova-cli/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/234
CB-9114: Log deprecation message when --usegit flag is used
CB-9114: Log deprecation message when --usegit flag is used
Moving towards using `cordova platform add
git-url#my
10 matches
Mail list logo
